1735870 - [wpt-sync] Sync PR 31249 - Fix some issues with <popup initiallyopen> and removing popups from doc

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31249 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31249
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Fix some issues with <popup initiallyopen> and removing popups from doc

The code previously had some issues when a showing popup was removed
from the document - an infinite loop could be hit at [1]. Additionally,
if a \<popup initiallyopen> popup was auto-shown and then immediately
removed from the document, it was possible to hit the event dispatch
forbidden scope check at [2].

This CL fixes both of these issues, primarily by using a post task to
show the popup for initiallyopen, and checking for connectedness
both while auto-showing, and while light-dismissing the popup.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document.cc;l=7009;drc=977dfd52386385c1e2e04212d1ef33ee37c7bd03
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/events/event_dispatcher.cc;l=65;drc=b6808699f68e698f5d71874440fb1a1da418fc3a

Fixed: 1259576
Change-Id: Id78f528130eb44397ded2cacc920fe6ae57bc1f8
Reviewed-on: https://chromium-review.googlesource.com/3221899
WPT-Export-Revision: 7331d5db962846f2427a8207f0c703a697bdc39b

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d22c61e38a3cc3719eda4fc657c6d90b8a902204

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
FAIL: 4

Chrome

OK : 4
PASS: 3
FAIL: 1

Safari

OK : 4
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-element-removal-2.tentative.html
Moving popup between documents shouldn't cause issues: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-element-removal.tentative.html
Removal from the document shouldn't cause issues: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-initiallyopen-2.tentative.html
The initiallyopen attribute should cause only the first popup to open: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-initiallyopen.tentative.html
The initiallyopen attribute should affect page load only: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/219b14edb463
[wpt PR 31249] - Fix some issues with <popup initiallyopen> and removing popups from doc, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6e9acf721c45
[wpt PR 31249] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/219b14edb463
https://hg.mozilla.org/mozilla-central/rev/6e9acf721c45