Closed Bug 1735969 Opened 3 months ago Closed 2 months ago

Implement PDocAccessible::TakeFocus on Windows

Categories

(Core :: Disability Access APIs, task)

Desktop
Windows
task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Without the cache, to make an Accessible take focus, Windows clients ask the IAccessible in the content process via COM. With the cache, we need to do this via async IPDL. We already do this on other platforms, so this should be pretty simple:

  1. Include TakeFocus in ipc/win/PDocAccessible.ipdl.
  2. Move RecvTakeFocus from other/DocAccessibleChild to DocAccessibleChildBase.
  3. Make IAccessible::accSelect use this for RemoteAccessible.
  1. Add TakeFocus in Windows PDocAccessible.
  2. Move RecvTakeFocus into DocAccessibleChildBase so it is used for all platforms.
  3. Move TakeFocus into the Accessible base class.
  4. Move the IPDL version of TakeFocus into RemoteAccessibleBase so it is used for all plaforms.
  5. Make the Windows RemoteAccessible::TakeFocus use the base (IPDL) implementation if the cache is enabled or COM otherwise.
  6. Use Accessible::TakeFocus for ATK, Mac, Windows and XPCOM.
Assignee: nobody → jteh
Status: NEW → ASSIGNED
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2cfcbb451b5
Unify Accessible::TakeFocus, thus allowing it to be used for RemoteAccessibles when the cache is enabled on Windows. r=morgan
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.