Closed Bug 1735996 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31263 - [MathML] Avoid DCHECK in NGSimplifiedLayoutAlgorithm constructor

Categories

(Core :: MathML, task, P4)

Product:
Core
Component:
MathML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31263 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31263
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[MathML] Avoid DCHECK in NGSimplifiedLayoutAlgorithm constructor

This patch just includes MathML elements in the if before checking
that old and new block sizes are equal.

The reason to do that is that the new block size is wrongly computed
for the \<math> element in the crash test.

BUG=1254572
TEST=external/wpt/mathml/crashtests/dynamic-height-within-table-cell.html

Change-Id: I6b2707cff3d94f3644c3b801bda948d908b395b3
Reviewed-on: https://chromium-review.googlesource.com/3226061
WPT-Export-Revision: 585c320c74d871f23aedf4a33573b7d94b4f052d

Component: web-platform-tests → MathML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f10280ac2c37
[wpt PR 31263] - [MathML] Fix DCHECK in NGSimplifiedLayoutAlgorithm constructor, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f10280ac2c37

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.