Closed Bug 1736000 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31264 - Update DCHECK for <= 1px tall fragmentainers in legacy write-back.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31264 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31264
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Update DCHECK for <= 1px tall fragmentainers in legacy write-back.

If block_size was zero, we'd pass the DCHECK, but we should check for
any block_size \<= 1px, since we don't only clamp for 0, but for any
values less than 1px. This code is in
NGBlockNode::PlaceChildrenInFlowThread(), and we'll clamp depending on
whether we have overflow or not. Some fragmentainers may have overflow,
while others may not.

This fixes external/wpt/css/css-paint-api/column-count-crash.https.html
when LayoutNGBlockFragmentation is enabled. Added two more crash tests
(the first one turned out to be an over-simplification, so I added
another one).

Bug: 829028
Change-Id: I19987f4b33df832d0298bfda81aadd1ea3ed557f
Reviewed-on: https://chromium-review.googlesource.com/3226101
WPT-Export-Revision: a6169d189cfe01b3ec86e35cb51500eb8d8575e4

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee8ccdac95d9
[wpt PR 31264] - Update DCHECK for <= 1px tall fragmentainers in legacy write-back., a=testonly

https://hg.mozilla.org/mozilla-central/rev/ee8ccdac95d9

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.