Closed Bug 1736043 Opened 4 years ago Closed 4 years ago

Call EqualStrings in TypeOfName instead of performing a pointer comparison

Categories

(Core :: JavaScript Engine: JIT, enhancement, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1736043: Use EqualStrings to compare typeof names instead of using pointer comparisons. r=evilpie!
48 bytes, text/x-phabricator-request
Details | Review

Call EqualStrings in TypeOfName instead of performing a pointer comparison, see https://phabricator.services.mozilla.com/D128074#inline-706606.

The difference between a pointer comparison and calling EqualStrings isn't
detectable right now, because the frontend will always emit an atom for well-known
names, but it makes the code more future proof if we call EqualStrings here.

Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Blocks: sm-opt-jits
Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P1
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bf8724e4a5b5 Use EqualStrings to compare typeof names instead of using pointer comparisons. r=evilpie

https://hg.mozilla.org/mozilla-central/rev/bf8724e4a5b5

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: