1736090 - Multiple JS errors with Import dialog

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Alessandro Castellani [:aleca]]

When opening the Import dialog, these errors show up in the terminal:

JavaScript error: chrome://messenger-newsblog/content/feed-subscriptions.js, line 2117: 
TypeError: can't access property "getAttribute", el is null
JavaScript error: chrome://messenger-newsblog/content/feed-subscriptions.js, line 775: 
TypeError: can't access property "focus", FeedSubscriptions.mTree is null

When interacting with the dialog, every click produces this error:

JavaScript error: chrome://messenger-newsblog/content/feed-subscriptions.js, line 2150: 
TypeError: can't access property "textContent", document.getElementById(...) is null

Comment 1

[Magnus Melin [:mkmelin]]

Harmless, but yes we should fix it.

Comment 2

[Alessandro Castellani [:aleca]]

I just discovered that the same "textContent" error prevents closing the dialog with the Escape key.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1736090 - move event handling back to feed-subscriptions.xhtml since feed-subscriptions.js is shared. r=aleca

That feed-subscriptions.js is "shared" is of course wrong. Things should be modularized, but since they are not...
Had regressed by https://hg.mozilla.org/comm-central/rev/fa72aeb98faaa70e429cf1ebc46d314866cd571b

I also notice the onClose() did apparently not exist at all.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0a6c70474a48
move event handling back to feed-subscriptions.xhtml since feed-subscriptions.js is shared. r=aleca