Closed Bug 1736103 Opened 2 months ago Closed 1 month ago

Fix browser_extension_correction.js to work when download improvements are enabled

Categories

(Firefox :: Downloads Panel, task, P1)

Desktop
All
task
Points:
1

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mhowell, Assigned: mhowell)

References

Details

(Whiteboard: [fidefe-mr11-downloads])

Attachments

(2 files)

browser_extension_correction.js in the exthandler tests expects to have the download modal open when a download begins, and much of its logic is based on that assumption. But turning on the browser.download.improvements_to_download_panel pref will disable the modal, so we need to alter the test to work under both scenarios.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3da967f1e8fa
Fix the download file extension correction test to not depend on the download modal when it is disabled. r=Gijs
Keywords: leave-open

On try and on my machine, after D128648 the test still times out because
for the test_broken_saved_handlerinfo_and_useless_mimetypes test, first
awaiting the task that gets passed means that the download has already
finished by the time we create the download finished promise.

This patch moves creating that promise before the task is started.
It also broadens the conditions in which we await this promise, because
in the case without file extensions and without a dialog, we were otherwise
no longer awaiting anything, which meant that the next test's check for
a finished download would resolve with the previous test's download, causing
confusion/breakage.

Keywords: leave-open
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1350a6c88f94
fix download file extension correction test some more for the no-download-modal case, r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

This was a test-only change, so it can't have been responsible for build times improvements.

Flags: needinfo?(aesanu)

Thanks for noticing, I managed to retrigger some data points and the graph shows the right improvement now.

Flags: needinfo?(aesanu)
You need to log in before you can comment on or make changes to this bug.