Left over MRE references in uninstaller

VERIFIED FIXED

Status

Core Graveyard
Installer: GRE
VERIFIED FIXED
15 years ago
10 years ago

People

(Reporter: Curt Patrick (gone), Assigned: Curt Patrick (gone))

Tracking

({topembed})

Trunk
x86
Windows NT
topembed

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: topembed)

Attachments

(1 attachment)

2.81 KB, patch
jbetak@netscape.com (away - not reading bugmail)
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
I had MREUser hardcoded as the default app in the uninstaller.  Not only should
this not be hardcoded, but it has since changed to GREUser.
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Whiteboard: topembed
(Assignee)

Comment 1

15 years ago
Created attachment 102396 [details] [diff] [review]
Patch 1
(Assignee)

Updated

15 years ago
Keywords: topembed
Comment on attachment 102396 [details] [diff] [review]
Patch 1

r=jbetak

(seems fairly straightforward :-)
Attachment #102396 - Flags: review+
Comment on attachment 102396 [details] [diff] [review]
Patch 1

>Index: wizard/windows/uninstall/extra.c
>+  char szDefaultApp[MAX_BUF];

4K is an insanely wasteful size for this string. (Beware complaining it's the
same as the other variables nearby or I'll ask you to fix those too.) See
setup.h and the various smaller sized buffers it defines. MAX_BUF_TINY is still
huge for this string, but wastes 20x less space.

sr=dveditz with that change
Attachment #102396 - Flags: superreview+

Comment 4

15 years ago
Comment on attachment 102396 [details] [diff] [review]
Patch 1

a=asa for checkin to 1.2beta (on behalf of drivers)
Attachment #102396 - Flags: approval+
(Assignee)

Comment 5

15 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 6

15 years ago
20021021 Trunk Build - Verified
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.