Closed
Bug 173619
Opened 23 years ago
Closed 23 years ago
Left over MRE references in uninstaller
Categories
(Core Graveyard :: Installer: GRE, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: curt, Assigned: curt)
Details
(Keywords: topembed, Whiteboard: topembed)
Attachments
(1 file)
|
2.81 KB,
patch
|
jbetak
:
review+
dveditz
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
I had MREUser hardcoded as the default app in the uninstaller. Not only should
this not be hardcoded, but it has since changed to GREUser.
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Whiteboard: topembed
|
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 102396 [details] [diff] [review]
Patch 1
r=jbetak
(seems fairly straightforward :-)
Attachment #102396 -
Flags: review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 102396 [details] [diff] [review]
Patch 1
>Index: wizard/windows/uninstall/extra.c
>+ char szDefaultApp[MAX_BUF];
4K is an insanely wasteful size for this string. (Beware complaining it's the
same as the other variables nearby or I'll ask you to fix those too.) See
setup.h and the various smaller sized buffers it defines. MAX_BUF_TINY is still
huge for this string, but wastes 20x less space.
sr=dveditz with that change
Attachment #102396 -
Flags: superreview+
|
||
Comment 4•23 years ago
|
||
Comment on attachment 102396 [details] [diff] [review]
Patch 1
a=asa for checkin to 1.2beta (on behalf of drivers)
Attachment #102396 -
Flags: approval+
|
|
Assignee | |
Comment 5•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•