1736196 - Missing booksmark toolbar in fullscreen mode

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect, P1)

Description

[never.sett1e]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

OS: Archlinux
Firefox: Developer Edition 94.0b6

Step 1: Open firefox developer addition in wayland session
Step 2: Setting booksmark toolbar visible. (You can see booksmark toolbar here)
Step 2: Press $Mod+f to enter fullscreen mode. (Booksmark toolbar is missing now)

Actual results:

Booksmark toolbar is missing

Expected results:

Booksmark toolbar should remain visible

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Seems intentional per this code.

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce it on Developer Edition 94.0b6 and Beta version 94.0b8 on Ubuntu 20.04 as well as Windows 10.
I'll change flags accordingly, please feel free to change it to an appropriate one.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1736196 - Consider the Bookmarks Toolbar a fullscreen toolbar. r?dao

Comment 5

[Mike Conley (:mconley) (:⚙️)]

This looks like it'd be a matter of adding fullscreentoolbar="true" to the PersonalToolbar here: https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/browser/base/content/navigator-toolbox.inc.xhtml#451-457

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hey rtestard,

Per dao's comment in https://phabricator.services.mozilla.com/D129180#4197894, he's right - it looks like at some point, we made a deliberate decision to always hide the bookmarks toolbar when in browser fullscreen mode.

Should that decision stand, and we WONTFIX this? Or do we feel like showing the bookmarks toolbar in fullscreen mode makes sense, and we should reverse that decision?

Comment 7

[Romain Testard [:RT]]

If this has been this way for years and this bug in the only instance where it got reported then I feel like it could cause more pain than good to change how we handle it at this point even though it would make logical sense to show the bookmark toolbar.
Was the deliberate decision argumented somewhere?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

I traced the code back as far as I could in hg. It looks like it's been this way (bookmarks toolbar not considered a "fullscreen toolbar") since at least 2008 when we transitioned from CVS to Mercurial.

I do see some history here: https://bugzilla.mozilla.org/show_bug.cgi?id=132187

Ooooold bugs. I expect this has just how it's been since the Netscape days. From what I'm gathering reading from some of these bugs, the idea might have been that a deliberate trade-off was made to hide the bookmarks toolbar in fullscreen to maximize screen real-estate.

Shall we persist that policy and dupe this to bug 132187?

Comment 9

[Emilio Cobos Álvarez [:emilio]]

I'd note that nowadays we show the bookmarks toolbar less often (only on newtab by default iirc?)

Comment 10

[Romain Testard [:RT]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #8)

I traced the code back as far as I could in hg. It looks like it's been this way (bookmarks toolbar not considered a "fullscreen toolbar") since at least 2008 when we transitioned from CVS to Mercurial.

I do see some history here: https://bugzilla.mozilla.org/show_bug.cgi?id=132187

Ooooold bugs. I expect this has just how it's been since the Netscape days. From what I'm gathering reading from some of these bugs, the idea might have been that a deliberate trade-off was made to hide the bookmarks toolbar in fullscreen to maximize screen real-estate.

Shall we persist that policy and dupe this to bug 132187?
The trade-off makes some sense and I think there is value in not changing the current behavior which seems to be working for users given rare bugs raised.
Chrome/Brave display nothing at all whereas Edge displays tabs/URL bar and bookmarks toolbar.
So agreed let's persist the current policy.