1736309 - 19.61 - 11.64% damp custom.inspector.reload.DAMP / damp custom.inspector.reload.DAMP + 6 more (Linux, OSX, Windows) regression on Mon October 11 2021

Status: NEW

(DevTools :: General, defect)

Description

[Julian Descottes [:jdescottes]]

Perfherder has detected a devtools performance regression from push 5cc276dd61cc430ee317ae2c9c83b02497496935. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
20%	damp custom.inspector.reload.DAMP	macosx1015-64-shippable-qr	e10s stylo webrender-sw	485.96 -> 581.25
20%	damp custom.inspector.reload.DAMP	macosx1015-64-shippable-qr	e10s stylo webrender	485.76 -> 580.83
16%	damp custom.inspector.reload.DAMP	windows10-64-shippable-qr	e10s stylo webrender-sw	564.40 -> 656.90
16%	damp custom.inspector.reload.DAMP	windows10-64-shippable-qr	e10s stylo webrender	563.72 -> 653.49
15%	damp custom.inspector.reload.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	541.10 -> 624.17
12%	damp custom.inspector.reload.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	614.40 -> 690.70
12%	damp custom.inspector.reload.DAMP	linux1804-64-shippable-qr	e10s stylo webrender-sw	603.09 -> 673.42
12%	damp custom.inspector.reload.DAMP	linux1804-64-shippable-qr	e10s stylo webrender	611.29 -> 682.45

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Julian Descottes [:jdescottes]]

Could be a regression from one of the Promise.jsm cleanups? Eg Bug 1734786 or Bug 1734592

Comment 2

[Julian Descottes [:jdescottes]]

Retriggers started on https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=NsmKQp5LQ8e5DDGYmp9YCw.0&tochange=866c35e38e9fbe463d30ca361921248e6f674409&fromchange=a28e38db75a196c5fa776c255f8733783aa7614f&searchStr=damp

Comment 3

[Julian Descottes [:jdescottes]]

I confirm the regression comes from the push containing the Promise.jsm changes: https://treeherder.mozilla.org/jobs?repo=autoland&revision=32a3cf57dd4396e123ebbba2f894e540528d0781

https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=autoland&newProject=autoland&newRevision=32a3cf57dd4396e123ebbba2f894e540528d0781&originalSignature=3140059&newSignature=3140059&framework=12&originalRevision=8b3140fe7b38031c47a347122a28f033fef0c9e9&page=1&showOnlyImportant=1

Setting regressed by Bug 1734786, but it might also be 1734592.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1734786

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, this regression is caused by the Promise.jsm usage removal
Do we want to do something or close?

Comment 6

[Julian Descottes [:jdescottes]]

Wontfixing for 96, we can investigate that for 97.

Comment 7

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

this fell off my radar, not sure if this is still actionable now