173631 - flawfinder warnings in embedding/browser/photon

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Stephen P. Morse]

Heikki ran flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 
branch.

flawfinder found 45 warnings in embedding/browser/photon code (1756-1800). Go 
through that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

1756) embedding/browser/photon/src/EmbedProgress.cpp:98 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

1757) embedding/browser/photon/src/EmbedProgress.cpp:186 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

1758) embedding/browser/photon/src/PtMozilla.cpp:398 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1759) embedding/browser/photon/src/PtMozilla.cpp:460 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1760) embedding/browser/photon/src/PtMozilla.cpp:479 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1761) embedding/browser/photon/src/PtMozilla.cpp:521 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1762) embedding/browser/photon/src/PtMozilla.cpp:531 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1763) embedding/browser/photon/src/PtMozilla.cpp:559 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1764) embedding/browser/photon/src/PtMozilla.cpp:631 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1765) embedding/browser/photon/src/PtMozilla.cpp:805 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1766) embedding/browser/photon/src/PtMozilla.cpp:810 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1767) embedding/browser/photon/src/PtMozilla.cpp:815 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1768) embedding/browser/photon/src/PtMozilla.cpp:820 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1769) embedding/browser/photon/src/PtMozilla.cpp:825 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1770) embedding/browser/photon/src/PtMozilla.cpp:830 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1771) embedding/browser/photon/src/PtMozilla.cpp:845 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1772) embedding/browser/photon/src/PtMozilla.cpp:855 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1773) embedding/browser/photon/src/PtMozilla.cpp:857 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1774) embedding/browser/photon/src/PtMozilla.cpp:864 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1775) embedding/browser/photon/src/PtMozilla.cpp:869 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1776) embedding/browser/photon/src/PtMozilla.cpp:876 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1777) embedding/browser/photon/src/PtMozilla.cpp:881 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1778) embedding/browser/photon/src/PtMozilla.cpp:886 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1779) embedding/browser/photon/src/PtMozilla.cpp:893 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1780) embedding/browser/photon/src/PtMozilla.cpp:898 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1781) embedding/browser/photon/src/PtMozilla.cpp:905 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

1782) embedding/browser/photon/src/PtMozilla.cpp:915 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1783) embedding/browser/photon/src/PtMozilla.cpp:920 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1784) embedding/browser/photon/src/PtMozilla.cpp:927 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1785) embedding/browser/photon/src/PtMozilla.cpp:932 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1786) embedding/browser/photon/src/PtMozilla.cpp:940 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1787) embedding/browser/photon/src/PtMozilla.cpp:947 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1788) embedding/browser/photon/src/PtMozilla.cpp:952 [2] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf. Risk is low because 
the source has a constant maximum length.

1789) embedding/browser/photon/src/PtMozilla.cpp:1015 [3] (buffer) getenv: 
Environment variables are untrustable input if they can be set by an attacker. 
They can have any content and length, and the same variable can be set more than 
once.. Check environment variables carefully before using them.

1790) embedding/browser/photon/src/PtMozilla.cpp:1016 [4] (buffer) sprintf: does 
not check for buffer overflows. Use snprintf or vsnprintf.

1791) embedding/browser/photon/src/PtMozilla.cpp:1016 [3] (buffer) getenv: 
Environment variables are untrustable input if they can be set by an attacker. 
They can have any content and length, and the same variable can be set more than 
once.. Check environment variables carefully before using them.

1792) embedding/browser/photon/src/nsUnknownContentTypeHandler.cpp:121 [4] 
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or 
strlcpy.

1793) embedding/browser/photon/src/nsUnknownContentTypeHandler.cpp:122 [4] 
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or 
strlcpy.

1794) embedding/browser/photon/tests/TestPhEmbed.cpp:126 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

1795) embedding/browser/photon/tests/TestPhEmbed.cpp:127 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

1796) embedding/browser/photon/tests/TestPhEmbed.cpp:224 [3] (buffer) getenv: 
Environment variables are untrustable input if they can be set by an attacker. 
They can have any content and length, and the same variable can be set more than 
once.. Check environment variables carefully before using them.

1797) embedding/browser/photon/tests/TestPhEmbed.cpp:321 [4] (buffer) sprintf: 
does not check for buffer overflows. Use snprintf or vsnprintf.

1798) embedding/browser/photon/tests/TestPhEmbed.cpp:328 [4] (buffer) sprintf: 
does not check for buffer overflows. Use snprintf or vsnprintf.

1799) embedding/browser/photon/tests/TestPhEmbed.cpp:507 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

1800) embedding/browser/photon/tests/TestPhEmbed.cpp:515 [4] (buffer) strcpy: 
does not check for buffer overflows. Consider using strncpy or strlcpy.

Comment 1

[Adam Lock]

Reassign to Photon owner.

Comment 2

[Stephen P. Morse]

29 more flawfinder bugs for photon (4297-4325)

4297) embedding/browser/photon/src/EmbedProgress.cpp:98 [4] (buffer) strcpy:
does not check for buffer overflows. Consider using strncpy or strlcpy.

4298) embedding/browser/photon/src/EmbedProgress.cpp:186 [4] (buffer) strcpy:
does not check for buffer overflows. Consider using strncpy or strlcpy.

4299) embedding/browser/photon/src/PtMozilla.cpp:398 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4300) embedding/browser/photon/src/PtMozilla.cpp:460 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4301) embedding/browser/photon/src/PtMozilla.cpp:479 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4302) embedding/browser/photon/src/PtMozilla.cpp:521 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4303) embedding/browser/photon/src/PtMozilla.cpp:531 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4304) embedding/browser/photon/src/PtMozilla.cpp:559 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4305) embedding/browser/photon/src/PtMozilla.cpp:631 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4306) embedding/browser/photon/src/PtMozilla.cpp:805 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4307) embedding/browser/photon/src/PtMozilla.cpp:810 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4308) embedding/browser/photon/src/PtMozilla.cpp:815 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4309) embedding/browser/photon/src/PtMozilla.cpp:820 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4310) embedding/browser/photon/src/PtMozilla.cpp:825 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4311) embedding/browser/photon/src/PtMozilla.cpp:830 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4312) embedding/browser/photon/src/PtMozilla.cpp:855 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4313) embedding/browser/photon/src/PtMozilla.cpp:857 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4314) embedding/browser/photon/src/PtMozilla.cpp:864 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4315) embedding/browser/photon/src/PtMozilla.cpp:869 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4316) embedding/browser/photon/src/PtMozilla.cpp:876 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4317) embedding/browser/photon/src/PtMozilla.cpp:881 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4318) embedding/browser/photon/src/PtMozilla.cpp:886 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4319) embedding/browser/photon/src/PtMozilla.cpp:893 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4320) embedding/browser/photon/src/PtMozilla.cpp:898 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4321) embedding/browser/photon/src/PtMozilla.cpp:905 [4] (buffer) strcpy: does
not check for buffer overflows. Consider using strncpy or strlcpy.

4322) embedding/browser/photon/src/PtMozilla.cpp:932 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4323) embedding/browser/photon/src/PtMozilla.cpp:1016 [4] (buffer) sprintf: does
not check for buffer overflows. Use snprintf or vsnprintf.

4324) embedding/browser/photon/src/nsUnknownContentTypeHandler.cpp:121 [4]
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or
strlcpy.

4325) embedding/browser/photon/src/nsUnknownContentTypeHandler.cpp:122 [4]
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or
strlcpy.

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Closing all open flawfinder bugs as WORKSFORME because we now have much better tools that do the same (well, better) kind of analysis (Coverity, Klocwork).