Closed Bug 173632 Opened 20 years ago Closed 16 years ago

flawfinder warnings in embedding/components/printingui

Categories

(Core :: Printing: Output, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
mozilla1.3alpha

People

(Reporter: morse, Assigned: rods)

References

Details

Heikki ran flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 
branch.

flawfinder found 1 warnings in printingui code (1801). Go through
that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

1801) embedding/components/printingui/src/win/nsPrintDialogUtil.cpp:880 [4] 
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or 
strlcpy.
Blocks: 148251
1 more flawfinder warning for printingui (4332)

4332) embedding/components/printingui/src/win/nsPrintDialogUtil.cpp:880 [4]
(buffer) strcpy: does not check for buffer overflows. Consider using strncpy or
strlcpy.

Target Milestone: --- → mozilla1.2final
Status: NEW → ASSIGNED
Target Milestone: mozilla1.2final → mozilla1.3alpha
Closing all open flawfinder bugs as WORKSFORME because we now have much better tools that do the same (well, better) kind of analysis (Coverity, Klocwork).
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.