Closed Bug 1736359 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31297 - Speculative fix for scroll-animation-inactive-timeline.html

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31297 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31297
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Speculative fix for scroll-animation-inactive-timeline.html

This test is flaking on Mac and Windows. The triggered failure is a
sanity check to ensure that the scroll timeline is inactive. The method
waitForNextFrame() assumes that document.timeline.currentTime has been
initialized prior to running the tests. With recent changes to
navigation, this assumption might no longer be valid. The tentative fix
adds an additional call to waitForNextFrame at the start of the test to
establish a frame boundary. Then the next wait will be guaranteed to
trigger in a later frame, thereby picking up the style change and
updating timeline.currentTime. Without the fix, it is possible for
promise to be resolved prior to running style update.

Bug: 1259150
Change-Id: I26617419f14ea034a5b915a02a5e96eb401f7e9f
Reviewed-on: https://chromium-review.googlesource.com/3226725
WPT-Export-Revision: 33498d930d498cdf9bf6b03bda21866456b81ec3

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 4

Safari

OK : 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/scroll-timelines/scroll-animation-inactive-timeline.html
Play pending task doesn't run when the timeline is inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct if scroll timeline is activated after animation.play call.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct if scroll timeline is activated after setting start time.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time is correct when the timeline becomes newly inactive and then active again.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02801e338875
[wpt PR 31297] - Speculative fix for scroll-animation-inactive-timeline.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/02801e338875

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.