1736370 - Tab icons often flicker/disappear when saving bookmark using dialog overlay

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kestrel]

Attachment: tab-icons-disappear-after-dialog.webm

STR:

1. Maximize window and open several tabs on Ubuntu 21.04.
2. Right-click a tab and choose Bookmark Tab.
3. Save bookmark.
4. Repeat several times.

The tab icons will sometimes flicker/disappear soon after the dialog overlay goes away. Moving the cursor over the tab strip makes them re-appear. Happens when using the Bookmark Tab/Link dialog overlay but not the bookmark star button in the address bar.

Affects both SW-WR and HW-WR.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f89214c9ce49c5411b18c49a1e404761459f266&tochange=052cbf82beba8b764f9bfbcf3aa1bed342e898fe

Regressed by Bug 1733384.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736370 - Make inert use the union of the change hints of the properties it affects. r=#layout-reviewers!

This is likely a bug in XUL layout, but this should restore the old
behavior and is the right thing to do.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eafd0a7d79a
Make inert use the union of the change hints of the properties it affects. r=jwatt

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7eafd0a7d79a

Comment 4

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 95.0a1 (2021-10-18) on Ubuntu 21.04.
The issue is no longer reproducible with Firefox 95.0b3 on Ubuntu 21.04, macOS 10.15 and Windows 10x64.