Regression: FF segfault with GTK_DEBUG=interactive (GTK inspector)
Categories
(Core :: Widget: Gtk, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox94 | --- | wontfix |
firefox95 | --- | wontfix |
firefox96 | --- | fixed |
People
(Reporter: valentin, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Launching Firefox with GTK_DEBUG=interactive
results in a segfault.
I tracked it down to this commit (not sure exactly why):
Bug 1721347 - Add OS theme info to about:support.
I’m using GTK 3.24.5-5 on a x86_64 Debian 10 system.
See also Thunderbird’s bug 1736369.
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 2•3 years ago
|
||
Can you please backtrace of the crash? You can find it at about:crashes - please submit it.
Thanks.
Reporter | ||
Comment 3•3 years ago
|
||
(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)
Can you please backtrace of the crash?
Sure: there you go.
Comment 6•3 years ago
|
||
This is a recursion in gfxPlatform::Init(), we call gtk_init(nullptr, nullptr) here, then mozilla::widget::IMContextWrapper::OnThemeChanged() which leads back to gfxPlatform::Init().
Comment 7•3 years ago
|
||
Hm, may the new LookAndFeel::GetThemeInfo() call at nsSystemInfo::Init() cause it?
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 8•3 years ago
|
||
I can reproduce it but I'm not sure where to put the check we're already in the nested loop. Emilio, any idea?
Thanks.
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
I can't repro on a debug build, does this need an opt build or something?
Assignee | ||
Comment 10•3 years ago
|
||
I don't know whether all this style provider business is still
necessary looking at bug 1461307, but this should help by avoiding
initializing LookAndFeel too early in any case.
Updated•3 years ago
|
Assignee | ||
Comment 11•3 years ago
|
||
I think that should help, but I couldn't repro the bug so if you could confirm it'd be great.
Comment 12•3 years ago
|
||
Set release status flags based on info from the regressing bug 1721347
Updated•3 years ago
|
Comment 13•3 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
I can't repro on a debug build, does this need an opt build or something?
I can reproduce that on nightly binaries produced by Mozilla under Wayland / Fedora 34.
Comment 14•3 years ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/6cebf8df6b78 Don't create IMContextWrapper GTK style provider unnecessarily. r=stransky
Reporter | ||
Comment 15•3 years ago
|
||
I can reproduce it using daily builds:
$ mozregression -c 'sh -c "GTK_DEBUG=interactive {binary}"'
INFO: Using local file: /tmp/mozregression/persist/2021-11-09--mozilla-central--firefox-96.0a1.en-US.linux-x86_64.tar.bz2
INFO: Running mozilla-central build for 2021-11-09
INFO: application_buildid: 20211109190508
INFO: application_version: 96.0a1
INFO: Running test command: `sh -c "GTK_DEBUG=interactive /tmp/tmplm_4d2pn/firefox/firefox"`
ExceptionHandler::GenerateDump cloned child ExceptionHandler::WaitForContinueSignal waiting for continue signal...
10832
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
INFO: Test command result: 11 (build is bad)
This is on two GNU/Linux x86_64 installs, one Debian oldstable and one Fedora rawhide.
Comment 16•3 years ago
|
||
bugherder |
Comment 17•3 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 18•3 years ago
|
||
Martin can you confirm the fix? Should we uplift this?
Comment 19•2 years ago
|
||
Yes, I can confirm the fix. I don't thin we need to uplift it as GTK_DEBUG=interactive is a debugging and rather unused feature.
Updated•2 years ago
|
Description
•