Closed Bug 1736409 Opened 1 month ago Closed 1 month ago

Use MDefinitionIterator in ArgumentsReplacer::run

Categories

(Core :: JavaScript Engine: JIT, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(3 files)

ArgumentsReplacer::run() uses MNodeIterator, but ignores any resume points, so we can actually directly use MDefinitionIterator.

ArgumentsReplacer::run() ignores any resume points, so we can directly use
MDefinitionIterator to iterate over all definitions.

The other caller to visitObjectGuard() was removed when unboxed objects were
removed, so we can move the function back into visitGuardShape().

Depends on D128764

Both initFromTemplateObject() methods are always returning true, so we might
as well change the return type to void.

Depends on D128765

Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56768df83e77
Part 1: Use MDefinitionIterator when iterating over definitions. r=iain
https://hg.mozilla.org/integration/autoland/rev/d5b2c877bbc7
Part 2: Inline visitObjectGuard() into visitGuardShape(). r=iain
https://hg.mozilla.org/integration/autoland/rev/1c4ef5f1be6f
Part 3: Return void instead of bool from initFromTemplateObject(). r=iain
You need to log in before you can comment on or make changes to this bug.