1736409 - Use MDefinitionIterator in ArgumentsReplacer::run

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[André Bargull [:anba]]

ArgumentsReplacer::run() uses MNodeIterator, but ignores any resume points, so we can actually directly use MDefinitionIterator.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1736409 - Part 1: Use MDefinitionIterator when iterating over definitions. r=iain!

ArgumentsReplacer::run() ignores any resume points, so we can directly use
MDefinitionIterator to iterate over all definitions.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1736409 - Part 2: Inline visitObjectGuard() into visitGuardShape(). r=iain!

The other caller to visitObjectGuard() was removed when unboxed objects were
removed, so we can move the function back into visitGuardShape().

Depends on D128764

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1736409 - Part 3: Return void instead of bool from initFromTemplateObject(). r=iain!

Both initFromTemplateObject() methods are always returning true, so we might
as well change the return type to void.

Depends on D128765

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56768df83e77
Part 1: Use MDefinitionIterator when iterating over definitions. r=iain
https://hg.mozilla.org/integration/autoland/rev/d5b2c877bbc7
Part 2: Inline visitObjectGuard() into visitGuardShape(). r=iain
https://hg.mozilla.org/integration/autoland/rev/1c4ef5f1be6f
Part 3: Return void instead of bool from initFromTemplateObject(). r=iain

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/56768df83e77
https://hg.mozilla.org/mozilla-central/rev/d5b2c877bbc7
https://hg.mozilla.org/mozilla-central/rev/1c4ef5f1be6f