1736484 - [rust 1.57] error: field is never read: `index`

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

 3:30.27     --> gfx/wr/webrender/src/profiler.rs:1433:5
 3:30.27      |
 3:30.27 1433 |     index: usize,
 3:30.27      |     ^^^^^^^^^^^^
 3:30.27      |
 3:30.27      = note: `-D dead-code` implied by `-D warnings`
 3:30.27 error: field is never read: `swizzle`
 3:30.27    --> gfx/wr/webrender/src/device/gl.rs:389:5
 3:30.27     |
 3:30.27 389 |     swizzle: Swizzle,
 3:30.27     |     ^^^^^^^^^^^^^^^^
 3:30.27 error: field is never read: `description`
 3:30.27    --> gfx/wr/webrender/src/internal_types.rs:690:5
 3:30.27     |
 3:30.27 690 |     description: String,
 3:30.27     |     ^^^^^^^^^^^^^^^^^^^
 3:30.62 error: could not compile `webrender` due to 3 previous errors

And past those:

 0:09.16 error: unused return value of `CString::from_raw` that must be used
 0:09.16     --> gfx/webrender_bindings/src/bindings.rs:1709:9
 0:09.16      |
 0:09.16 1709 |         CString::from_raw(msg);
 0:09.16      |         ^^^^^^^^^^^^^^^^^^^^^^^
 0:09.16      |
 0:09.16 note: the lint level is defined here
 0:09.16     --> gfx/webrender_bindings/src/lib.rs:5:9
 0:09.16      |
 0:09.16 5    | #![deny(warnings)]
 0:09.16      |         ^^^^^^^^
 0:09.16      = note: `#[deny(unused_must_use)]` implied by `#[deny(warnings)]`
 0:09.16      = note: call `drop(from_raw(ptr))` if you intend to drop the `CString`

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1736484 - Fix new dead-code warnings with rust 1.57.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8815353a549
Fix new dead-code warnings with rust 1.57. r=gfx-reviewers,nical

Comment 3

[Atila Butkovits]

Backed out for causing wrench failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3e809c865ca0dbb165f0285a9490793cfdb4763b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=eUnL6kfxSuqpv_jnkbcRUw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b8815353a5494ac19ff23f9e09020229167e92ea

Failure log: https://treeherder.mozilla.org/logviewer?job_id=355408634&repo=autoland&lineNumber=13608

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50c191c8b3eb
Fix new dead-code warnings with rust 1.57. r=gfx-reviewers,nical

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/50c191c8b3eb