Closed Bug 1736536 Opened 3 years ago Closed 3 years ago

Expect the "Show me how" button to be a primary button (blue / highlight colour instead of grey)

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
Firefox 95
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- verified
firefox95 --- verified

People

(Reporter: sbadau, Assigned: Gijs)

References

Details

(Whiteboard: [fidefe-mr11-close-tabs])

Attachments

(2 files)

Screenshot 2021-10-19 at 12.10.57.png
215.53 KB, image/png
Details
Bug 1736536 - make the 'show me how' button in the session store notification bar use the primary color, r?NeilDeakin
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

Affected platforms:
All

Affected versions:
Firefox 94 beta 7
Nightly 95.0a1

Steps to reproduce:

  1. Launch Firefox with a new profile.
  2. Open a few tabs on various sites.
  3. Close Firefox and then reopen it with the same profile as used in step 1.
  4. Observe the infobar.

Expected Results:
The "Show me how button" should be blue as in the documentation.

Actual Results:
The "Show me how button" is gray.

Summary: The "Show you how" button of the session restore Infobar is not according to the documentation → The "Show me how" button of the session restore Infobar is not according to the documentation
Severity: S3 → S4
Summary: The "Show me how" button of the session restore Infobar is not according to the documentation → Expect the "Show me how" button to be a primary button (blue / highlight colour instead of grey)
Whiteboard: [fidefe-mr11-close-tabs]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Points: --- → 1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3738556dd340
make the 'show me how' button in the session store notification bar use the primary color, r=NeilDeakin

https://hg.mozilla.org/mozilla-central/rev/3738556dd340

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9246968 [details]
Bug 1736536 - make the 'show me how' button in the session store notification bar use the primary color, r?NeilDeakin

Beta/Release Uplift Approval Request

  • User impact if declined: Button is grey instead of blue
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): I'm adding a single line to a button definition so it is treated as a "primary" button and gets the right class
  • String changes made/needed: Nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9246968 - Flags: approval-mozilla-beta?

Comment on attachment 9246968 [details]
Bug 1736536 - make the 'show me how' button in the session store notification bar use the primary color, r?NeilDeakin

Approved for 94.0rc1.

Attachment #9246968 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the latest Nightly 95.0a1 and Firefox 94 beta 10 - tested on macOS Big Sur 11.6, Ubuntu 20.04 x 64 and Windows 10 x64.

Status: RESOLVED → VERIFIED
status-firefox94: fixed → verified
status-firefox95: fixed → verified
Flags: qe-verify+

Verified as fixed also on Firefox 94 RC (build 2) - on macOS Big Sur 11.6, Ubuntu 20.04 x 64, and Windows 10 x64.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: