1736604 - Remove the GCPolicy and container sweep methods

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

There's one last use of these, and then we can remove the duplicated methods entirely. From now on everything can use traceWeak instead of needsSweep/sweep.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1736604 - Part 1: Replace sweeping with tracing weak edges in WeakRef implementation r=sfink

Depends on D128900

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1736604 - Part 2: Remove GCPolicy and container needsSweep and sweep methods r=sfink

This functionality has been replaced by the traceWeak methods.

Depends on D128901

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1736604 - Part 3: Rename MapSweepPolicy to MapEntryGCPolicy r=sfink

It's only used for traceWeak it's true, but it's like a GCPolicy for the map
entry itself.

Depends on D128902

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1ef1c085097
Part 1: Replace sweeping with tracing weak edges in WeakRef implementation r=sfink
https://hg.mozilla.org/integration/autoland/rev/31b0cbcc6e84
Part 2: Remove GCPolicy and container needsSweep and sweep methods r=sfink
https://hg.mozilla.org/integration/autoland/rev/3ef8aa197b0a
Part 3: Rename MapSweepPolicy to MapEntryGCPolicy r=sfink

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e1ef1c085097
https://hg.mozilla.org/mozilla-central/rev/31b0cbcc6e84
https://hg.mozilla.org/mozilla-central/rev/3ef8aa197b0a

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing crashes (Bug 1737399)

Backout link: https://hg.mozilla.org/integration/autoland/rev/ec26a424e94243edf601aa8997ebed803db9be35

Comment 7

[Alexandru Michis [:malexandru]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/ec26a424e94243edf601aa8997ebed803db9be35

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10d25724c8be
Part 1: Replace sweeping with tracing weak edges in WeakRef implementation r=sfink
https://hg.mozilla.org/integration/autoland/rev/820758a84c4d
Part 2: Remove GCPolicy and container needsSweep and sweep methods r=sfink
https://hg.mozilla.org/integration/autoland/rev/3f566bda25e0
Part 3: Rename MapSweepPolicy to MapEntryGCPolicy r=sfink

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/10d25724c8be
https://hg.mozilla.org/mozilla-central/rev/820758a84c4d
https://hg.mozilla.org/mozilla-central/rev/3f566bda25e0