Closed Bug 1736658 Opened 3 years ago Closed 3 years ago

Remove or update probes expiring in Firefox 96: browser.search.data_transferred before Gecko central version number gets increased to 96 on 2021-11-01

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 + fixed

People

(Reporter: aryx, Assigned: timhuang)

References

Details

(Whiteboard: [probe-expiry-alert][necko-triaged])

Attachments

(2 files, 3 obsolete files)

[Tracking Requested - why for this release]:
The test toolkit/components/search/tests/xpcshell/test_searchSuggest.js depends on the probe.

+++ This bug was initially created as a clone of Bug #1694852 +++

The following Firefox probes will expire in the next major Firefox nightly release: version 96 [1].

browser.search.data_transferred

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Flags: needinfo?(tihuang)
Summary: Remove or update probes expiring in Firefox 96: browser.search.data_transferred → Remove or update probes expiring in Firefox 96: browser.search.data_transferred before Gecko central version number gets increased to 96 on 2021-11-01

browser/components/search/test/browser/browser_search_telemetry_sources_ads.js also depends on it.

Reminder: This has to be landed by Sunday EOD and Thursday is the last working day.

The probe is no longer needed. I will remove this.

Flags: needinfo?(tihuang)
Assignee: nobody → tihuang
Status: NEW → ASSIGNED
Attachment #9247862 - Attachment description: Bug 1736658 - Remove code that collects 'browser.search.data_transferred'. r?standard8 → Bug 1736658 - Part 2: Remove tests and code that collects 'browser.search.data_transferred'. r?standard8
Attachment #9247863 - Attachment is obsolete: true
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0f2619a6ba3 Part 1: Remove 'browser.search.data_transferred' from Scalars.yaml. r=dimi https://hg.mozilla.org/integration/autoland/rev/d7414af6a093 Part 2: Remove tests and code that collects 'browser.search.data_transferred'. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

It looks like we still need the data and want to extend this probe to never expire.

Please help me to back out the patches, I will submit a new patch for extending the probe.

Flags: needinfo?(aryx.bugmail)
Status: RESOLVED → REOPENED
Flags: needinfo?(aryx.bugmail)
Resolution: FIXED → ---
Target Milestone: 95 Branch → ---
Attached file bug-1736658-request

The new request for extending the probe to 'never expired'.

Attachment #9248291 - Flags: data-review?(willkg)

Comment on attachment 9248291 [details]
bug-1736658-request

Looks good!

Attachment #9248291 - Flags: data-review?(willkg) → data-review+
Attachment #9247861 - Attachment is obsolete: true
Attachment #9247862 - Attachment is obsolete: true
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36066738a8fc Extend telemetry proble 'browser.search.data_transferred' to never expired. r=dimi
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [probe-expiry-alert] → [probe-expiry-alert][necko-triaged]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Priority: P3 → P2

(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #10)

Backed out as per request from dev. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/8c0a2435832b59a7c600aa3667b8e09ca88213cd

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/8c0a2435832b

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Regressions: 1739130
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: