1736692 - Netflix is not using video IOSurfaces

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Markus Stange [:mstange]]

When playing Netflix on macOS, we seem to upload the video as textures and do the conversion to RGB in WebRender.

Matt Woodrow found the following:

It looks like the GMP decoder (the Widevine/DRM decoder) isn't passing the needed aAllocator param - https://searchfox.org/mozilla-central/rev/8130ddcaa7e214d341371194bb1d2f97078cab00/dom/media/platforms/agnostic/gmp/GMPVideoDecoder.cpp#63-67

Fixing that (it's available in the CreateDecoderParams passed to the ctor) will likely improve performance even without [Brad's] changes, as well as hopefully fixing [the issue with Netflix not hitting detached mode]!

Comment 1

[Markus Stange [:mstange]]

There are a few more callers of VideoData::CreateAndCopyData which don't pass an aAllocator param, which means that none of them will get IOSurface upload or detached mode: AOMDecoder, OmxDataDecoder, and BlankDecoderModule. I'll make the parameter non-optional and change these callers to pass nullptr.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1736692 - Make GMP and ChromiumCDM decoders pass a non-null KnowsCompositor instance to VideoData::CreateAndCopyData, so that we can do optimized video frame upload. r=jrmuizel

Comment 3

[Jeff Muizelaar [:jrmuizel]]

The call to VideoData::CreateAndCopyData in ChromiumCDMParent::CreateVideoFrame is the one that needs to not be null.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Triaging, please adjust values as you see fit.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00d8ff18f852
Make GMP and ChromiumCDM decoders pass a non-null KnowsCompositor instance to VideoData::CreateAndCopyData, so that we can do optimized video frame upload. r=jrmuizel

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/00d8ff18f852

Comment 7

[Timea Cernea [:tbabos][inactive]]

NI? myself for QA verification.

Comment 8

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Nightly 95.0a1 (2021-10-21) (64-bit) on MacOS 11 M1.
After the video is in fullscreen and all the overlays disappear (age rating, skip recapp, etc) the video will be detached.

Edit: Also works only if subtitles are disabled.