Closed Bug 1736701 Opened 3 months ago Closed 2 months ago

Checkbox on X-Frame-Options error page is misaligned (should be in the middle of the page, not on the left/start)

Categories

(Firefox :: Security, defect)

Firefox 93
Desktop
All
defect

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- fixed

People

(Reporter: soeren.hentzschel, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screenshot

STR:

  1. Open a website with a X-Frame-Options error, for example https://labs.w0s.jp/http/x-frame-options/
  2. Look at the "Report errors like this" checkbox below the "X-Frame-Options: DENY" headline.

Expected:

The checkbox is aligned with the content of the error page.

Actual:

The checkbox is positioned on the left of the error page.

It's a regression from bug 1724230 (introduced in Firefox 93).

Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: checkbox on X-Frame-Options error page is bad positioned → Checkbox on X-Frame-Options error page is misaligned (should be in the middle of the page, not on the left/start)

#overrideWeakCryptoPanel was removed in bug 1321778, so the CSS is dead and I removed it.
Otherwise I'm dragging the 2 advanced panel bits into using .hidden instead of
inline CSS, and using the single 'advanced-panel' class to handle more of their styling,
with the box background/border moving to an ID selector to keep it specific to the
bad cert bits.
I've left the #certificateErrorDebugInformation without this new class because the
alignment of the 'pre' style text with cert info looks off if it's centered, so
keeping it full-width seemed like the desired effect here.

The severity field is not set for this bug.
:johannh, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mail)
Attachment #9246860 - Attachment description: Bug 1736701 - fix display of error reporting checkbox on x-frame-options:deny pages, r?johannh,pbz → Bug 1736701 - fix display of error reporting checkbox on x-frame-options:deny pages, r?pbz
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/034731aeb4ec
fix display of error reporting checkbox on x-frame-options:deny pages, r=pbz,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: needinfo?(mail)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.