Get rid of nsContentUtils::sNameSpaceManager
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(2 files)
This seems pointless. Maybe this was some kind of ancient optimization. We can call nsNameSpaceManager::GetInstance() instead of nsContentUtils::NameSpaceManager().
Assignee | ||
Comment 1•3 years ago
|
||
Emilio, I'm trying to get rid of nsContentUtils::sNameSpaceManager, but there's a reference to it in the form of structs::nsContentUtils_sNameSpaceManager in servo/components/style/gecko/wrapper.rs. I tried to change that to structs::nsNameSpaceManager_sInstance, which seems to exist in structs.rs, but I get the error "cannot find value nsNameSpaceManager_sInstance
in module structs
" when I try to build it. Do you know what I might be doing wrong? Thanks.
Assignee | ||
Comment 2•3 years ago
|
||
(This is not urgent at all, in case that's not obvious...)
Comment 3•3 years ago
|
||
You need to whitelist that static explicitly, will send a patch.
Assignee | ||
Comment 4•3 years ago
|
||
Call nsNameSpaceManager::GetInstance() instead.
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Comment 6•3 years ago
|
||
nsNameSpaceManager::sInstance and nsContentUtils::sNameSpaceManager aren't cleared at precisely the same point in shutdown, and the former will be recreated if it is accessed after it was cleared, but hopefully that doesn't matter.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41958fb8de30 part 1 - Get rid of nsContentUtils::NameSpaceManager(). r=peterv https://hg.mozilla.org/integration/autoland/rev/849b7e5b8220 part 2 - Remove nsContentUtils::sNameSpaceManager. r=peterv
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41958fb8de30
https://hg.mozilla.org/mozilla-central/rev/849b7e5b8220
Description
•