Closed Bug 1736752 Opened 3 years ago Closed 2 years ago

Update libjxl to new version 116326a86ad857ace17f0424fc219bb1acf5150d from 2021-10-19 19:36:44

Categories

(Core :: Graphics: ImageLib, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: update-bot, Assigned: saschanaz)

References

Details

(Whiteboard: [3pl-filed][task_id: WyTBwLlgRgK6v9NEXNcPtQ])

Attachments

(1 file)

This update covers 53 commits, including 45 new upstream commits I've never filed a bug on before. (They're the top 45.):


116326a86ad857ace17f0424fc219bb1acf5150d by Lode

https://github.com/libjxl/libjxl-/commit/116326a86ad857ace17f0424fc219bb1acf5150d
Authored: 2021-10-14 13:40:09 +0200
Committed: 2021-10-19 21:36:44 +0200

Simplify box content output

This is a preparation for supporting reconstructed jpeg metadata, where
we'll then need two JxlBoxContentDecoders to handle the output to user
and output to jpeg metadata each with possibly different brob-box
handling

Also added tests for input streaming of brob and non-brob box decoding

Files Added:

  • lib/jxl/box_content_decoder.cc
  • lib/jxl/box_content_decoder.h

Files Deleted:

  • lib/jxl/decode_brob_box.cc
  • lib/jxl/decode_brob_box.h

Files Added:

  • lib/jxl.cmake
  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc
  • lib/lib.gni

afa2d327b4779df15d9bdedb7582eaa3ea811066 by Alex Deymo

https://github.com/libjxl/libjxl-/commit/afa2d327b4779df15d9bdedb7582eaa3ea811066
Authored: 2021-10-19 17:46:58 +0200
Committed: 2021-10-19 15:46:58 +0000

Use PRIuS/PRIdS macros to printf size_t/ssize_t. (#746)

PRIuS is defined to either "zu" or "Iu" depending on the platform
allowing to print size_t values in MSYS2. This macro is meant to be used
similarly to PRIu32, so that the "%" is not part of the macro allowing
expressions like "%3" PRIuS instead of "%3zu". Similarly, PRIdS is
used for ssize_t.

This patch replaces all the occurrences and adds a test to bash_test.sh.

Fixes #718.

Files Added:

  • bash_test.sh
  • examples/decode_oneshot.cc
  • examples/jxlinfo.c
  • lib/extras/codec_pgx.cc
  • lib/extras/codec_png.cc
  • lib/extras/codec_pnm.cc
  • lib/extras/codec_psd.cc
  • lib/extras/codec_test.cc
  • lib/jxl/aux_out.cc
  • lib/jxl/aux_out.h
  • lib/jxl/base/cache_aligned.cc
  • lib/jxl/blending.cc
  • lib/jxl/butteraugli/butteraugli.cc
  • lib/jxl/coeff_order_test.cc
  • lib/jxl/common.h
  • lib/jxl/convolve_test.cc
  • lib/jxl/dec_ans.cc
  • lib/jxl/dec_external_image.cc
  • lib/jxl/dec_frame.cc
  • lib/jxl/dec_group.cc
  • lib/jxl/dec_modular.cc
  • lib/jxl/dec_patch_dictionary.cc
  • lib/jxl/enc_color_management.cc
  • lib/jxl/enc_detect_dots.cc
  • lib/jxl/enc_modular.cc
  • lib/jxl/fields.cc
  • lib/jxl/fields.h
  • lib/jxl/frame_header.cc
  • lib/jxl/gauss_blur_test.cc
  • lib/jxl/headers.cc
  • lib/jxl/image.h
  • lib/jxl/image_bundle.cc
  • lib/jxl/image_ops.h
  • lib/jxl/image_ops_test.cc
  • lib/jxl/image_test_utils.h
  • lib/jxl/jpeg/enc_jpeg_data_reader.cc
  • lib/jxl/jpeg/jpeg_data.cc
  • lib/jxl/jxl_test.cc
  • lib/jxl/linalg.h
  • lib/jxl/modular/encoding/enc_debug_tree.cc
  • lib/jxl/modular/encoding/enc_encoding.cc
  • lib/jxl/modular/encoding/encoding.cc
  • lib/jxl/modular/transform/squeeze.cc
  • lib/jxl/modular/transform/transform.cc
  • lib/jxl/quant_weights.cc
  • lib/jxl/sanitizers.h
  • lib/jxl/splines.cc
  • lib/jxl/splines_test.cc
  • lib/profiler/profiler.cc
  • tools/args.h
  • tools/benchmark/benchmark_stats.cc
  • tools/benchmark/benchmark_xl.cc
  • tools/box/box_list_main.cc
  • tools/butteraugli_main.cc
  • tools/cjxl.cc
  • tools/djxl.cc
  • tools/djxl_main.cc
  • tools/epf_main.cc
  • tools/speed_stats.cc
  • tools/xyb_range.cc

4b7a944f65bea99139140c77ccd4568b9f04caae by vtorri

https://github.com/libjxl/libjxl-/commit/4b7a944f65bea99139140c77ccd4568b9f04caae
Authored: 2021-10-19 15:20:54 +0200
Committed: 2021-10-19 15:20:54 +0200

Windows: install DLL in /bin instead of /lib (#748)

Files Added:

  • lib/jxl.cmake
  • lib/jxl_threads.cmake

498967906f1fb60272d97ad043650f96040ca8da by vtorri

https://github.com/libjxl/libjxl-/commit/498967906f1fb60272d97ad043650f96040ca8da
Authored: 2021-10-18 23:45:03 +0200
Committed: 2021-10-18 23:45:03 +0200

Windows: fix build with MSYS2 (#743)

Files Added:

  • third_party/skcms.cmake

0787fd490cef096062a9636811951a66a594ed2e by xiota

https://github.com/libjxl/libjxl-/commit/0787fd490cef096062a9636811951a66a594ed2e
Authored: 2021-10-18 12:02:41 -0700
Committed: 2021-10-18 21:02:41 +0200

Update Windows build guides (#581)

to include BUILD_SHARED_LIBS

Files Added:

  • doc/developing_in_windows_msys.md
  • doc/developing_with_crossroad.md

e7c99a116c4084a8332929f423dfb137ac9fa57f by Luca Versari

https://github.com/libjxl/libjxl-/commit/e7c99a116c4084a8332929f423dfb137ac9fa57f
Authored: 2021-10-18 21:01:40 +0200
Committed: 2021-10-18 21:01:40 +0200

Adapt conformance testing to 18181-3. (#583)

Also implement metadata and color comparison when no colorspace
conversion is required.

Files Added:

  • tools/conformance/conformance.py
  • tools/conformance/djxl_conformance.cc
  • tools/conformance/generator.py

b5e9e0d1612c7d14f21ebca86b6ac05a35efca6e by vtorri

https://github.com/libjxl/libjxl-/commit/b5e9e0d1612c7d14f21ebca86b6ac05a35efca6e
Authored: 2021-10-18 20:57:49 +0200
Committed: 2021-10-18 20:57:49 +0200

Windows: add clang++ warning flags only when clang compiler is used (#724)

update AUTHORS

Files Added:

  • AUTHORS
  • lib/CMakeLists.txt

e0f9f6e1085a09c79917e4ffd8bae1c13f0a434c by Lode Vandevenne

https://github.com/libjxl/libjxl-/commit/e0f9f6e1085a09c79917e4ffd8bae1c13f0a434c
Authored: 2021-10-18 20:56:25 +0200
Committed: 2021-10-18 20:56:25 +0200

Use msan unpoison to prevent false alerts (#739)

Files Added:

  • lib/jxl/decode_brob_box.cc
  • lib/jxl/jpeg/dec_jpeg_data.cc
  • lib/jxl/sanitizers.h

1fda55c5f00b049aa1586d5332e2f56f2d0fb104 by Sami Boukortt

https://github.com/libjxl/libjxl-/commit/1fda55c5f00b049aa1586d5332e2f56f2d0fb104
Authored: 2021-10-18 16:10:34 +0200
Committed: 2021-10-18 18:13:37 +0200

Set intensity target and tone mapping data in JxlEncoderSetBasicInfo

Fixes #694.

Files Added:

  • lib/jxl/encode.cc

35ca355660a89819e52013fa201284cb50768f80 by Alex Xu

https://github.com/libjxl/libjxl-/commit/35ca355660a89819e52013fa201284cb50768f80
Authored: 2021-10-15 18:08:02 +0000
Committed: 2021-10-15 20:08:02 +0200

Replace 0 pointer with NULL in docs (fixes #610) (#713)

Files Added:

  • lib/include/jxl/memory_manager.h

b9d102956b3635b0c06bacd8d29d0e5e76b5c524 by Alex Deymo

https://github.com/libjxl/libjxl-/commit/b9d102956b3635b0c06bacd8d29d0e5e76b5c524
Authored: 2021-10-15 15:04:51 +0200
Committed: 2021-10-15 15:04:51 +0200

Use -fmacro-prefix-map when supported. (#737)

Fixes #730

Files Added:

  • CMakeLists.txt

ee084dff54c519bc21d103af58f5d9ba44b0d526 by Alex Deymo

https://github.com/libjxl/libjxl-/commit/ee084dff54c519bc21d103af58f5d9ba44b0d526
Authored: 2021-10-15 15:04:16 +0200
Committed: 2021-10-15 15:04:16 +0200

Fix gbench build in Docker (#738)

gtest is not a dependency of gbench and it doesn't seem that we need it.

Files Added:

  • lib/jxl/gauss_blur_gbench.cc

1343b513005f2d0a6481d753d2b20f944de29707 by Lode

https://github.com/libjxl/libjxl-/commit/1343b513005f2d0a6481d753d2b20f944de29707
Authored: 2021-10-14 17:56:48 +0200
Committed: 2021-10-15 13:20:51 +0200

Don't decode the jbrd box when recon not requested

When no jpeg reconstruction is requested, there's no reason to parse the
box. This has no visible effect, at least at this time because currently
it can only output a reconstructed JPEG if both the reconstruction event
and the full image event were requested.

Files Added:

  • lib/jxl/decode.cc

795ba9c3dd45294947d6777910e0ac6e04e59ef4 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/795ba9c3dd45294947d6777910e0ac6e04e59ef4
Authored: 2021-10-14 17:56:35 +0200
Committed: 2021-10-14 17:56:35 +0200

return early (before init/allocation) if no actual decode will happen (#700)

Files Added:

  • lib/jxl/dec_frame.cc
  • lib/jxl/dec_frame.h
  • lib/jxl/decode.cc

89565c50865d1ea4e28f532101b99e88b76dd91c by Alex Xu

https://github.com/libjxl/libjxl-/commit/89565c50865d1ea4e28f532101b99e88b76dd91c
Authored: 2021-10-14 15:49:51 +0000
Committed: 2021-10-14 17:49:51 +0200

Run RoundtripAnimationPatches only if gif enabled (#702)

Files Added:

  • AUTHORS
  • lib/jxl/jxl_test.cc

7f69c207dc45a27c760ed5a9a349e42ab2cd9347 by Lode

https://github.com/libjxl/libjxl-/commit/7f69c207dc45a27c760ed5a9a349e42ab2cd9347
Authored: 2021-10-14 15:39:55 +0200
Committed: 2021-10-14 16:08:08 +0200

Possibly fix msan issue

Fix an uninitlized memory comparison in the test itself, as detected by
msan in the github pipeline on this line.

I can't reproduce this issue even when running with msan on my machine,
so I can't verify if this truly fixes the issue, but it makes sense.

Files Added:

  • lib/jxl/decode_test.cc

40085e0782b4c29ebf326bde077dbb0f43af248a by Lode

https://github.com/libjxl/libjxl-/commit/40085e0782b4c29ebf326bde077dbb0f43af248a
Authored: 2021-10-14 15:14:19 +0200
Committed: 2021-10-14 15:51:09 +0200

fix std::fmin compilation issue

When building with msan I get compiler errors about std::fmin, including
<cmath> fixes it. Likely this is platform dependent since I don't get it
without msan, and the continuous integration doesn't seem to get the
error with msan either.

Files Added:

  • plugins/gimp/file-jxl-save.cc

28a26e6bb4e613e2a2a1e18a37e329a0c1cd430c by Sami Boukortt

https://github.com/libjxl/libjxl-/commit/28a26e6bb4e613e2a2a1e18a37e329a0c1cd430c
Authored: 2021-10-13 12:16:47 +0200
Committed: 2021-10-13 19:11:23 +0200

Tool for display->HLG conversions

Files Added:

  • lib/extras/hlg.cc
  • lib/extras/hlg.h
  • tools/hdr/display_to_hlg.cc

Files Added:

  • lib/jxl_extras.cmake
  • lib/lib.gni
  • tools/CMakeLists.txt
  • tools/hdr/README.md
  • tools/hdr/pq_to_hlg.cc
  • tools/hdr/render_hlg.cc
  • tools/hdr/tone_map.cc

66375cb9cbd7e1c91f67042a3185a4c4db2feee9 by Sami Boukortt

https://github.com/libjxl/libjxl-/commit/66375cb9cbd7e1c91f67042a3185a4c4db2feee9
Authored: 2021-09-11 20:38:45 +0200
Committed: 2021-10-13 19:11:23 +0200

Tools for creating 3D LUTs

Files Added:

  • tools/hdr/generate_lut_template.cc
  • tools/hdr/texture_to_cube.cc

Files Added:

  • tools/CMakeLists.txt
  • tools/hdr/README.md

0f387788921c76e9e3490c5aba3fd80cf2fb3cfe by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/0f387788921c76e9e3490c5aba3fd80cf2fb3cfe
Authored: 2021-10-11 00:46:18 +0200
Committed: 2021-10-11 00:46:18 +0200

cleanup dead/unused code in butteraugli (#657)

Files Added:

  • lib/jxl/butteraugli/butteraugli.cc
  • lib/jxl/butteraugli/butteraugli.h
  • lib/jxl/butteraugli_wrapper.cc
  • lib/jxl/enc_butteraugli_pnorm.cc

a67be330ad36ea1b380d7573c7e13f9e77f72a2e by Luca Versari

https://github.com/libjxl/libjxl-/commit/a67be330ad36ea1b380d7573c7e13f9e77f72a2e
Authored: 2021-10-08 01:03:09 +0200
Committed: 2021-10-08 22:48:20 +0200

Tighten butteraugli bounds, and make sure they don't increase again.

Files Added:

  • lib/jxl/decode_test.cc
  • lib/jxl/jxl_test.cc
  • lib/jxl/modular_test.cc
  • lib/jxl/passes_test.cc
  • lib/jxl/test_utils.h

482d0a24f891c641caae4369676ed303406dccac by Luca Versari

https://github.com/libjxl/libjxl-/commit/482d0a24f891c641caae4369676ed303406dccac
Authored: 2021-10-07 21:08:40 +0200
Committed: 2021-10-08 21:56:37 +0200

Remove (almost) all uses of C++ distributions/RNGs.

C++ distribution implementations may be different between libstdc++ and
libc++, causing inconsistencies in tests under say msan and possibly
different (Linux) distributions.

This PR implements a few common distributions and a RNG and uses it
throughout the codebase, except in a couple of places (fuzzer_corpus
mostly) where consistency is not as important.

Diff-based on https://github.com/libjxl/libjxl/pull/703

Files Added:

  • lib/jxl/base/random.cc
  • lib/jxl/base/random.h

Files Added:

  • lib/extras/codec_test.cc
  • lib/jxl.cmake
  • lib/jxl/ans_test.cc
  • lib/jxl/bit_reader_test.cc
  • lib/jxl/coeff_order_test.cc
  • lib/jxl/convolve_test.cc
  • lib/jxl/dec_patch_dictionary.cc
  • lib/jxl/decode_test.cc
  • lib/jxl/enc_patch_dictionary.cc
  • lib/jxl/entropy_coder_test.cc
  • lib/jxl/fast_math_test.cc
  • lib/jxl/gauss_blur_test.cc
  • lib/jxl/image_ops_test.cc
  • lib/jxl/image_test_utils.h
  • lib/jxl/lehmer_code_test.cc
  • lib/jxl/linalg_test.cc
  • lib/jxl/modular/encoding/enc_encoding.cc
  • lib/jxl/modular/encoding/enc_ma.cc
  • lib/jxl/modular_test.cc
  • lib/jxl/opsin_inverse_test.cc
  • lib/jxl/quant_weights_test.cc
  • lib/jxl/quantizer_test.cc
  • lib/jxl/test_utils.h
  • lib/jxl/toc_test.cc
  • lib/lib.gni
  • tools/benchmark/benchmark_xl.cc
  • tools/djxl_fuzzer.cc
  • tools/flicker_test/split_view.cc
  • tools/flicker_test/split_view.h
  • tools/transforms_fuzzer.cc

3e0ec6cd964e11d2cbf3b442017f11f92df67efd by Luca Versari

https://github.com/libjxl/libjxl-/commit/3e0ec6cd964e11d2cbf3b442017f11f92df67efd
Authored: 2021-10-07 20:20:17 +0200
Committed: 2021-10-08 21:56:37 +0200

Remove Robust and Descriptive statistics.

They were for the most part unused in the main library, and caused some
interop problems because of the use of RNGs. This gets rid of a
significant amount of LoC (~1k), as well as the only uses of
std::normal_distribution and std::poisson_distribution.

Also converts the benchmarks in gauss_blur_test to use gbench.

No BPP or pnorm changes.

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------
jxl:d0.7        13270  3401128    2.0503469   3.860  23.290   1.47008669   0.48388256  0.992127114835      0
jxl:d1          13270  2682333    1.6170262   4.023  24.737   1.78285837   0.61856733  1.000239584869      0
jxl:d2          13270  1693780    1.0210838   4.286  25.686   3.12266779   0.98560314  1.006383363499      0
jxl:d4          13270  1017240    0.6132362   3.840  19.237   5.74765110   1.58872606  0.974264363420      0
jxl:d8          13270   580162    0.3497467   3.691  18.627   9.35825157   2.58073121  0.902602273036      0
Aggregate:      13270  1555941    0.9379884   3.935  22.126   3.37857946   1.03878140  0.974364851568      0

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------
jxl:d0.7        13270  3401128    2.0503469   3.714  24.224   1.47008669   0.48388256  0.992127114835      0
jxl:d1          13270  2682333    1.6170262   3.867  25.641   1.78285837   0.61856733  1.000239584869      0
jxl:d2          13270  1693780    1.0210838   4.263  24.652   3.12266779   0.98560314  1.006383363499      0
jxl:d4          13270  1017240    0.6132362   3.731  20.015   5.74765110   1.58872606  0.974264363420      0
jxl:d8          13270   580162    0.3497467   3.645  18.540   9.35825157   2.58073121  0.902602273036      0
Aggregate:      13270  1555941    0.9379884   3.838  22.434   3.37857946   1.03878140  0.974364851568      0

Files Added:

  • lib/jxl_tests.cmake

b2f7bdcd48c439ac53e7d1d8961a76fc291d2765 by Lode

https://github.com/libjxl/libjxl-/commit/b2f7bdcd48c439ac53e7d1d8961a76fc291d2765
Authored: 2021-10-06 17:16:16 +0200
Committed: 2021-10-08 21:41:06 +0200

Support decoding brob boxes in API

Implements decoding of brob boxes, and adds test with Exif brob box

Files Added:

  • lib/jxl/decode_brob_box.cc
  • lib/jxl/decode_brob_box.h

Files Added:

  • lib/jxl.cmake
  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc
  • lib/lib.gni

204f87a5e4d684544b13900109abf040dc0b402b by Luca Versari

https://github.com/libjxl/libjxl-/commit/204f87a5e4d684544b13900109abf040dc0b402b
Authored: 2021-10-07 20:20:17 +0200
Committed: 2021-10-08 20:15:42 +0200

Remove Robust and Descriptive statistics.

They were for the most part unused in the main library, and caused some
interop problems because of the use of RNGs. This gets rid of a
significant amount of LoC (~1k), as well as the only uses of
std::normal_distribution and std::poisson_distribution.

Also converts the benchmarks in gauss_blur_test to use gbench.

No BPP or pnorm changes.

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------
jxl:d0.7        13270  3401128    2.0503469   3.860  23.290   1.47008669   0.48388256  0.992127114835      0
jxl:d1          13270  2682333    1.6170262   4.023  24.737   1.78285837   0.61856733  1.000239584869      0
jxl:d2          13270  1693780    1.0210838   4.286  25.686   3.12266779   0.98560314  1.006383363499      0
jxl:d4          13270  1017240    0.6132362   3.840  19.237   5.74765110   1.58872606  0.974264363420      0
jxl:d8          13270   580162    0.3497467   3.691  18.627   9.35825157   2.58073121  0.902602273036      0
Aggregate:      13270  1555941    0.9379884   3.935  22.126   3.37857946   1.03878140  0.974364851568      0

Encoding      kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------
jxl:d0.7        13270  3401128    2.0503469   3.714  24.224   1.47008669   0.48388256  0.992127114835      0
jxl:d1          13270  2682333    1.6170262   3.867  25.641   1.78285837   0.61856733  1.000239584869      0
jxl:d2          13270  1693780    1.0210838   4.263  24.652   3.12266779   0.98560314  1.006383363499      0
jxl:d4          13270  1017240    0.6132362   3.731  20.015   5.74765110   1.58872606  0.974264363420      0
jxl:d8          13270   580162    0.3497467   3.645  18.540   9.35825157   2.58073121  0.902602273036      0
Aggregate:      13270  1555941    0.9379884   3.838  22.434   3.37857946   1.03878140  0.974364851568      0

Files Added:

  • lib/jxl/gauss_blur_gbench.cc

Files Deleted:

  • lib/jxl/base/descriptive_statistics.cc
  • lib/jxl/base/descriptive_statistics.h
  • lib/jxl/base/robust_statistics.h
  • lib/jxl/descriptive_statistics_test.cc
  • lib/jxl/noise_distributions.h
  • lib/jxl/robust_statistics_test.cc

Files Added:

  • lib/jxl.cmake
  • lib/jxl/enc_noise.cc
  • lib/jxl/gauss_blur_test.cc
  • lib/jxl/quantizer.cc
  • lib/jxl/rational_polynomial_test.cc
  • lib/jxl_benchmark.cmake
  • lib/jxl_tests.cmake
  • lib/lib.gni
  • lib/profiler/profiler.cc
  • tools/benchmark/benchmark_xl.cc
  • tools/speed_stats.cc

541988a1fadd793215cf956172aa743840a4e70d by Lode

https://github.com/libjxl/libjxl-/commit/541988a1fadd793215cf956172aa743840a4e70d
Authored: 2021-10-07 21:21:28 +0200
Committed: 2021-10-07 23:04:32 +0200

Fix streaming box output issues

Added a test for getting box output in a streaming fashion, and fixed
the issues this uncovered.

Files Added:

  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc

6a3f0ce87f82f8cc241216cd649cad9e0ca2028f by Ziemowit Zabawa

https://github.com/libjxl/libjxl-/commit/6a3f0ce87f82f8cc241216cd649cad9e0ca2028f
Authored: 2021-10-06 17:28:44 +0200
Committed: 2021-10-07 21:48:32 +0200

Update lodepng to 20210627

Files Added:

  • deps.sh
  • third_party/lodepng

83b05d7583d37fe93bdaa5e8d306782152f38ca1 by Sami Boukortt

https://github.com/libjxl/libjxl-/commit/83b05d7583d37fe93bdaa5e8d306782152f38ca1
Authored: 2021-10-07 17:30:52 +0200
Committed: 2021-10-07 19:16:40 +0200

decode_test: do not rely on the ICC profile being converted to enum values

With lcms2, there is a slight mismatch (perhaps to investigate later)
preventing the transfer function to be identified.

Fixes #500.

Files Added:

  • lib/jxl/decode_test.cc

47a65ca478549de952c2733b21219e4c33c33f18 by Lode

https://github.com/libjxl/libjxl-/commit/47a65ca478549de952c2733b21219e4c33c33f18
Authored: 2021-10-06 17:22:22 +0200
Committed: 2021-10-06 17:41:14 +0200

Tiny fix: match StartBox in no-transcode version

Make the function signatures in JPEGXL_ENABLE_TRANSCODE_JPEG and
no-JPEGXL_ENABLE_TRANSCODE_JPEG versions of the code match

Files Added:

  • lib/jxl/decode_to_jpeg.h

70bb9e93590da4455613319daee0c6d3ba9d7721 by Lode

https://github.com/libjxl/libjxl-/commit/70bb9e93590da4455613319daee0c6d3ba9d7721
Authored: 2021-10-06 15:25:49 +0200
Committed: 2021-10-06 16:32:06 +0200

Implement outputting box data (non-brob)

This implements outputting box data to user buffers. In this PR, only
non-brob boxes are supported, the decompression with brotli is not yet
implemented.

Also added list of boxes to the jxlinfo.c example, and fixed the
decode_exif_metadata.cc example to ensure it works.

Files Added:

  • examples/decode_exif_metadata.cc
  • examples/jxlinfo.c
  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc

95ab996b5587ae9a59ecdd6b5fe66d3e087895c4 by Lode

https://github.com/libjxl/libjxl-/commit/95ab996b5587ae9a59ecdd6b5fe66d3e087895c4
Authored: 2021-10-05 12:34:50 +0200
Committed: 2021-10-05 15:34:04 +0200

Implement JXL_DEC_BOX event and getting box info

This MR does not yet implement box contents, and no output buffer can be
set yet. However, box type and size can be requested.

Files Added:

  • lib/include/jxl/decode.h
  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc

92453e94287b35c4d293adef4c7109112c966720 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/92453e94287b35c4d293adef4c7109112c966720
Authored: 2021-10-05 12:46:51 +0200
Committed: 2021-10-05 12:46:51 +0200

remove debug printing instrumentation on header fields (#674)

Files Added:

  • lib/jxl/fields.cc
  • lib/jxl/fields.h

8917d6afbcd98e29f85e81c0e8596f94a5c1d4aa by w

https://github.com/libjxl/libjxl-/commit/8917d6afbcd98e29f85e81c0e8596f94a5c1d4aa
Authored: 2021-10-03 02:34:42 -0700
Committed: 2021-10-04 22:59:07 +0200

Fix skcms subdirectory build

Files Added:

  • AUTHORS
  • third_party/skcms.cmake

5a77302bf9aa04913d40303523fc4be20b5023e9 by Alex Deymo

https://github.com/libjxl/libjxl-/commit/5a77302bf9aa04913d40303523fc4be20b5023e9
Authored: 2021-10-04 19:36:50 +0200
Committed: 2021-10-04 19:36:50 +0200

Mark release v0.6 in the CHANGELOG (#686)

Files Added:

  • CHANGELOG.md

0c5cf04fb6c18d6a89d5a3b215eb2f7750947db5 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/0c5cf04fb6c18d6a89d5a3b215eb2f7750947db5
Authored: 2021-10-03 13:21:33 +0200
Committed: 2021-10-03 11:21:33 +0000

silly copy/paste error (#682)

Files Added:

  • lib/jxl/enc_cache.cc

743bbdd364b736e6af8826faae63be4d33bb1555 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/743bbdd364b736e6af8826faae63be4d33bb1555
Authored: 2021-10-03 12:54:21 +0200
Committed: 2021-10-03 12:54:21 +0200

tweaks to lossless jpeg recompression (#679)

Files Added:

  • lib/jxl/enc_cache.cc
  • lib/jxl/enc_frame.cc
  • lib/jxl/enc_modular.cc
  • lib/jxl/enc_modular.h

c31dca74e68f6d1550692a2e28780499fa4e7dd5 by Alex Deymo

https://github.com/libjxl/libjxl-/commit/c31dca74e68f6d1550692a2e28780499fa4e7dd5
Authored: 2021-10-01 16:27:01 +0200
Committed: 2021-10-01 16:27:01 +0200

Remove sys/platform/ppc.h include. (#678)

According to the comment this include was used for
__ppc_get_timebase_freq at some point in this file but nowadays that
function is not there, so we can remove the include. Fixes #677.

Files Added:

  • tools/cpu/cpu.cc

5a024e5bf5b9b93da698c7f6cb06abb874b73c4c by Lode

https://github.com/libjxl/libjxl-/commit/5a024e5bf5b9b93da698c7f6cb06abb874b73c4c
Authored: 2021-09-24 11:30:40 +0200
Committed: 2021-10-01 15:23:07 +0200

Simplify box handling in decode.cc

This simplifies the box handling loop, so that it will be possible to
implement support for decoder output of metadata boxes, and handling the
metadata of reconstructed jpeg

Files Added:

  • lib/include/jxl/decode.h
  • lib/jxl/decode.cc
  • lib/jxl/decode_to_jpeg.h

2782da94289f4ae883e233061e5a2ac9279c3b8e by Luca Versari

https://github.com/libjxl/libjxl-/commit/2782da94289f4ae883e233061e5a2ac9279c3b8e
Authored: 2021-10-01 12:02:01 +0200
Committed: 2021-10-01 13:20:43 +0200

Fix progressive previews with chroma subsampling.

Fixes https://github.com/libjxl/libjxl/issues/673

Also adds a test.

Files Added:

  • lib/jxl/dec_group.cc
  • lib/jxl/dec_reconstruct.cc
  • lib/jxl/dec_reconstruct.h
  • lib/jxl/jxl_test.cc

7f065057f2ec26844bf59e614e57186e8ee78b27 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/7f065057f2ec26844bf59e614e57186e8ee78b27
Authored: 2021-09-28 18:26:37 +0200
Committed: 2021-10-01 09:42:01 +0200

drop ==, != from dec_params.h

Files Added:

  • lib/jxl/dec_params.h
  • tools/benchmark/benchmark_codec_jxl.cc

c527a525dd50425f2e3be932f44d905f3399f2cc by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/c527a525dd50425f2e3be932f44d905f3399f2cc
Authored: 2021-10-01 00:09:44 +0200
Committed: 2021-10-01 00:09:44 +0200

cleanup image_bundle and enc_image_bundle (#672)

Files Added:

  • lib/extras/codec_exr.cc
  • lib/extras/codec_jpg.cc
  • lib/extras/codec_pgx.cc
  • lib/extras/codec_png.cc
  • lib/extras/codec_pnm.cc
  • lib/jxl/enc_butteraugli_comparator.cc
  • lib/jxl/enc_comparator.cc
  • lib/jxl/enc_image_bundle.cc
  • lib/jxl/enc_xyb.cc
  • lib/jxl/image_bundle.h
  • tools/benchmark/benchmark_codec_webp.cc

86eed136f8f9e7babd347ec772c2fa94fddd3c1f by Alex Deymo

https://github.com/libjxl/libjxl-/commit/86eed136f8f9e7babd347ec772c2fa94fddd3c1f
Authored: 2021-09-30 12:27:00 +0200
Committed: 2021-09-30 12:27:00 +0200

Load from other codecs to an interleaved image format. (#634)

This patch defines a new set of classes like PackedImage that represent
the image concepts as define in the external C API. These classes
represent a jxl decoded image that will be used as the output from the
the decoder API and input to the jxl encoder API.

Migrated most codec parsers (all excepts PSD) to use this format to load
still and animation images without extra channels (besides alpha).

Manually tested .gif and .exr files. .png and .jpg are extensively
tested by the unittests.

Files Added:

  • lib/extras/packed_image.h
  • lib/extras/packed_image_convert.cc
  • lib/extras/packed_image_convert.h

Files Added:

  • lib/extras/codec.cc
  • lib/extras/codec_apng.cc
  • lib/extras/codec_apng.h
  • lib/extras/codec_exr.cc
  • lib/extras/codec_exr.h
  • lib/extras/codec_gif.cc
  • lib/extras/codec_gif.h
  • lib/extras/codec_jpg.cc
  • lib/extras/codec_jpg.h
  • lib/extras/codec_pgx.cc
  • lib/extras/codec_pgx.h
  • lib/extras/codec_pgx_test.cc
  • lib/extras/codec_png.cc
  • lib/extras/codec_png.h
  • lib/extras/codec_pnm.cc
  • lib/extras/codec_pnm.h
  • lib/extras/codec_psd.cc
  • lib/extras/color_hints.cc
  • lib/extras/color_hints.h
  • lib/jxl_extras.cmake
  • lib/lib.gni
  • tools/benchmark/benchmark_codec_jpeg.cc
  • tools/benchmark/benchmark_codec_png.cc

c2266c4bacaf355f3e8fe63c8d3a63f83b3cecfe by Alex Deymo

https://github.com/libjxl/libjxl-/commit/c2266c4bacaf355f3e8fe63c8d3a63f83b3cecfe
Authored: 2021-09-30 09:38:53 +0200
Committed: 2021-09-30 09:38:53 +0200

Update SOVERSION to reflect v0.6 API/ABI changes. (#667)

0.y.z version can have API/ABI changes during development but we should
mark those in the shared library SOVERSION. This uses MAJOR.MINOR for
major version 0, and just MAJOR for version after 1.0.

Files Added:

  • lib/CMakeLists.txt

233db00a7879764419c604665206d63489ec7ec0 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/233db00a7879764419c604665206d63489ec7ec0
Authored: 2021-09-29 10:00:43 +0200
Committed: 2021-09-29 08:00:43 +0000

try RCTs and custom WP also for single-group images (#651)

Files Added:

  • lib/jxl/enc_modular.cc
  • lib/jxl/modular_test.cc

43fa117061d119de9ae4b8f648d5c5d11e62b12d by Lode Vandevenne

https://github.com/libjxl/libjxl-/commit/43fa117061d119de9ae4b8f648d5c5d11e62b12d
Authored: 2021-09-29 09:24:59 +0200
Committed: 2021-09-29 09:24:59 +0200

Fix issue with partial codestream boxes (#664)

Fixes issue discovered in https://github.com/libjxl/libjxl/pull/651/:

It was saving previous box data to the codestream buffer when a next
partial codestream box is encountered. However, if there were other
unrelated boxes in between, it already updated position pointers and no
longer included the previous box data.

Now it instead saves the codestream data to the internal buffer
immediately if it's a partial codestream, rather than waiting for the
next one. It has to do this anyway to concatenate the separate buffers,
so the memory usage is about the same.

Also removed variable box_begin that was never read from.

Files Added:

  • lib/jxl/decode.cc

7ce0f7868f95bccc5f66a16e20d083019ac67a75 by Iulia Comșa

https://github.com/libjxl/libjxl-/commit/7ce0f7868f95bccc5f66a16e20d083019ac67a75
Authored: 2021-09-28 15:15:32 +0200
Committed: 2021-09-28 23:14:15 +0300

Add diffusion parameters.

Files Added:

  • lib/jxl/modular/transform/enc_palette.cc

99fc3f68e1d2460ff0aba2dadce2a7834cf6ffd2 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/99fc3f68e1d2460ff0aba2dadce2a7834cf6ffd2
Authored: 2021-09-28 18:13:02 +0200
Committed: 2021-09-28 16:13:02 +0000

add test for lossless modular handling of custom float data (#662)

Files Added:

  • lib/jxl/modular_test.cc

0f6d04ccedc90becca82dcebe78cc315d442d536 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/0f6d04ccedc90becca82dcebe78cc315d442d536
Authored: 2021-09-28 17:35:41 +0200
Committed: 2021-09-28 17:35:41 +0200

remove uint24 (#659)

Files Added:

  • lib/jxl/base/byte_order.h
  • lib/jxl/dec_external_image.cc
  • lib/jxl/enc_external_image.cc

b046a7237a63d5403b6361df5cef755327d6761c by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/b046a7237a63d5403b6361df5cef755327d6761c
Authored: 2021-09-28 17:07:01 +0200
Committed: 2021-09-28 15:07:01 +0000

some more enc_bit_writer cleanup (#660)

Files Added:

  • lib/jxl/enc_bit_writer.h

fabf99260df7d70f166b0bee36e08272fcfd9a1e by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/fabf99260df7d70f166b0bee36e08272fcfd9a1e
Authored: 2021-09-28 15:43:09 +0200
Committed: 2021-09-28 13:43:09 +0000

cleanup deprecated += in BitWriter (#658)

Files Added:

  • lib/jxl/enc_bit_writer.cc
  • lib/jxl/enc_bit_writer.h

fd06f61d0e49a28b8b0894e227994b40d2e446d0 by Lode

https://github.com/libjxl/libjxl-/commit/fd06f61d0e49a28b8b0894e227994b40d2e446d0
Authored: 2021-09-16 20:55:26 +0200
Committed: 2021-09-28 14:17:04 +0200

Add several options to the encoder

More to follow in next MR's

Files Added:

  • lib/include/jxl/encode.h
  • lib/jxl/encode.cc

4049834fa68bb54480932d9c165edeecd198c778 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/4049834fa68bb54480932d9c165edeecd198c778
Authored: 2021-09-28 14:02:05 +0200
Committed: 2021-09-28 12:02:05 +0000

fix allocation not being done before use in some cases (#655)

In some cases (progressive rendering with a flush at an unfortunate moment), the allocations done in InitForAC() were not yet done when they are already expected to be done to be able to render partial images, causing segfault. I think this could happen when DC is available but ACGlobal not yet, or something like that. This fixes that.

Files Added:

  • lib/jxl/dec_frame.cc
  • lib/jxl/dec_frame.h
  • lib/jxl/dec_group.cc

c06061c2139052676bb00ca5798a2838b93acb02 by Jon Sneyers

https://github.com/libjxl/libjxl-/commit/c06061c2139052676bb00ca5798a2838b93acb02
Authored: 2021-09-28 13:55:29 +0200
Committed: 2021-09-28 11:55:29 +0000

silly typo in excluding test-only stuff (#656)

Files Added:

  • ci.sh

./mach vendor media/libjxl/moz.yaml failed with the following message:

0:00.23 Latest commit is 116326a86ad857ace17f0424fc219bb1acf5150d from 2021-10-19T19:36:44Z
0:00.23 Fetching code archive from https://github.com/libjxl/libjxl/archive/116326a86ad857ace17f0424fc219bb1acf5150d.tar.gz
0:01.68 rm -rf third_party/jpeg-xl
0:01.69 Unpacking upstream files from third_party/jpeg-xl.
0:01.96 Removing unnecessary files.
0:01.96 Removing: ['third_party/jpeg-xl/doc/', 'third_party/jpeg-xl/third_party/testdata/', 'third_party/jpeg-xl/tools/', 'third_party/jpeg-xl/.gitmodules', 'third_party/jpeg-xl/.github', 'third_party/jpeg-xl/.gitlab-ci.yml', 'third_party/jpeg-xl/.gitignore']
0:01.97 Updating moz.yaml.
Found release: commit 702cd54420513b754edb60e33b9a4438f7e9ca00 (2021-09-28T08:19:14Z).

Found revision: 702cd54420513b754edb60e33b9a4438f7e9ca00

0:01.98 Updating files
0:01.98 Registering changes with version control.
0:02.68 Updating moz.build files
0:06.15 Could not add third_party/jpeg-xl/lib/extras/hlg.cc to the appropriate moz.build file
0:06.15 Could not add third_party/jpeg-xl/lib/extras/packed_image_convert.cc to the appropriate moz.build file
0:06.16 Could not remove third_party/jpeg-xl/lib/jxl/base/descriptive_statistics.h from the appropriate moz.build file
0:06.16 Could not remove third_party/jpeg-xl/lib/jxl/base/robust_statistics.h from the appropriate moz.build file
0:06.16 Could not remove third_party/jpeg-xl/lib/jxl/descriptive_statistics_test.cc from the appropriate moz.build file
0:06.17 Could not remove third_party/jpeg-xl/lib/jxl/noise_distributions.h from the appropriate moz.build file
0:06.17 Could not remove third_party/jpeg-xl/lib/jxl/robust_statistics_test.cc from the appropriate moz.build file
0:06.17 This is a deficiency in ./mach vendor and should be reported to the Updatebot maintainers.

Flags: needinfo?(krosylight)

This is a deficiency in ./mach vendor and should be reported to the Updatebot maintainers.

NI'ing updatebot people as such. Also, bug 1733013 was updating to an earlier 2021-09-28 commit to a later commit at that same day, and somehow ended up being closed without pinging anyone.

Flags: needinfo?(tom)
Flags: needinfo?(jewilde)
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Flags: needinfo?(krosylight)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Flags: needinfo?(tom)
Flags: needinfo?(jewilde)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: