1736819 - Library window toolbar button menu disappears if the mouse moves at all while clicking

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Kestrel]

Attachment: library-toolbar-menu-drag.webm

STR:

1. Open the Library window (Ctrl+Shift+O).
2. Press and hold the "Import and Backup" toolbar button and move the cursor.

Expected:

Menu opens and stays open.

Actual:

Menu opens but immediately disappears when the cursor moves. Cannot press and hold to open the menu and select an item in one click like other menus. Also makes it difficult to keep the menu open if you don't have a steady hand while clicking.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3aa256c255f664c500714c34a3b9e353e545d196&tochange=0a4598992141595a1baba8fb30652b59b26d4358

Most likely regressed by Bug 1241885.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

As the library uses system titlebar, we should not add drag area there.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1736819 - fix draggability of menu elements, r?NeilDeakin

Comment 4

[:Gijs (he/him)]

I came across this looking for bug 1694546 so I might as well fix it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1befcf606799
fix draggability of menu elements, r=NeilDeakin

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/1befcf606799

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this on Firefox 98.0(20220304153049) on Linux x86_64(Ubuntu 20.04). Confirmed as fixed on Firefox 99.0b3(20220313185831) and Nightly 100.0a1(20220314094248).