Closed Bug 1736824 Opened 2 years ago Closed 2 years ago

"consoleFront is null" exception from toolbox.js:723 when reloading a page

Categories

(DevTools :: Framework, defect, P3)

defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox93 unaffected, firefox94 unaffected, firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

STR:

  • open a page with DevTools opened
  • reload the page

Nothing looks broken, but we do get the following exception:

console.error: (new TypeError("can't access property \"off\", consoleFront is null", "resource://devtools/client/framework/toolbox.js", 723))
TypeError: can't access property "off", consoleFront is null: _onTargetDestroyed@resource://devtools/client/framework/toolbox.js:723:7
_emit@resource://devtools/shared/event-emitter.js:244:34
emit@resource://devtools/shared/event-emitter.js:190:18
emit@resource://devtools/shared/event-emitter.js:342:18
_onTargetDestroyed@resource://devtools/shared/commands/target/target-command.js:294:28
_destroyExistingTargetsOnTargetSwitching@resource://devtools/shared/commands/target/target-command.js:233:14
_onTargetAvailable@resource://devtools/shared/commands/target/target-command.js:168:14
_emit@resource://devtools/shared/event-emitter.js:244:34
emit@resource://devtools/shared/event-emitter.js:190:18
emit@resource://devtools/shared/event-emitter.js:342:18
_onTargetAvailable@resource://devtools/client/fronts/watcher.js:60:10
_emit@resource://devtools/shared/event-emitter.js:244:34
emit@resource://devtools/shared/event-emitter.js:190:18
emit@resource://devtools/shared/event-emitter.js:342:18
onPacket@resource://devtools/shared/protocol/Front.js:336:13
onPacket@resource://devtools/client/devtools-client.js:482:13
send/<@resource://devtools/shared/transport/local-transport.js:68:25
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
Assignee: nobody → poirot.alex

Set release status flags based on info from the regressing bug 1717724

We weren't removing listeners on the target actor,
and also some late DOMContentLoaded/load event may be fired.
We were getting exception because of late events when closing the toolbox on a still-loading page.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da1008b1d3a5
[devtools] Fix "consoleFront is null" exception when reloading the page. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c15a4365cbde
[devtools] Really stop listener and emitting events in DocumentEventsListener after being destroyed. r=nchevobbe
Severity: -- → S3
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.