1736830 - <X11/ICE/ICElib.h> and <X11/SM/SMlib.h> are not checked for during configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[tt_1]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

hey everyone, I noticed this a while ago: when compiling firefox from source with X11 support, the compile will fail unless libICE and libSM headers are available.

Actual results:

the build fails with these errors:

• /var/tmp/portage/www-client/firefox-93.0/work/firefox-93.0/toolkit/xre/nsNativeAppSupportUnix.cpp:32:12: fatal error: 'X11/ICE/ICElib.h' file not found
• /var/tmp/portage/www-client/firefox-93.0/work/firefox-93.0/toolkit/xre/nsNativeAppSupportUnix.cpp:33:12: fatal error: 'X11/SM/SMlib.h' file not found

Expected results:

it seems to my layman eyes that the libs themselve are never used by firefox to link against, but the headers must be present.

So please check for their presence during configure, thank you.

I will provide the full build log later on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1736830 - Check for libice and libsm headers during configure.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1736830 - Be more consistent wrt package_desc in pkg_check_modules.

Make @depends functions and direct values have the same level of
convenience.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4d1678f31bb
Be more consistent wrt package_desc in pkg_check_modules. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/1845a9bc917b
Check for libice and libsm headers during configure. r=firefox-build-system-reviewers,mhentges,andi

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1736830) for causing build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=OgfkXqjpRKOsJRCqcVCfZQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1845a9bc917b7a0731728dec98f5b762c85392ad

Log: https://treeherder.mozilla.org/logviewer?job_id=356255458&repo=autoland&lineNumber=1014

Backout: https://hg.mozilla.org/integration/autoland/rev/dd99452b671854d9f1f3079a051fc4822161a993

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e819776339de
Be more consistent wrt package_desc in pkg_check_modules. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/14c4c39bc05b
Check for libice and libsm headers during configure. r=firefox-build-system-reviewers,mhentges,andi

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e819776339de
https://hg.mozilla.org/mozilla-central/rev/14c4c39bc05b

Comment 8

[tt_1]

Thank you, this enables a check during configure for the headers. I removed them on purpose, and swiftly got an error about them missing.

Is a backport to firefox-91 possible?

Comment 9

[Mike Hommey [:glandium]]

I'm not super convinced that it's worth it. In most cases, those libs are pulled from installing others. As a matter of fact, the code using those headers was added 5 years ago, and you filed this bug only now.