1736850 - Category navigation is not functional on westelm.co.uk with ETP - Strict enabled

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Oana Arbuzov [:oanaarbuzov]]

Attachment: 138109848-075ae92e-857e-48b4-b723-545fefb256b0.png

Environment:
Browser / Version: Firefox Nightly 95.0a1 (2021-10-19)
Operating System: macOS Big Sur 11.6

Prerequisites:
ETP - Strict enabled.

Steps to reproduce:

1. Navigate to https://www.westelm.co.uk/
2. Click a category from top bar (e.g "Bed Linen").
3. Click a different category (e.g "Bath").
4. Observe behavior.

Expected Behavior:
The products from the new selected category are loaded.

Actual Behavior:
A spinner is displayed, but the products from the new selected category are not loaded.

Notes:

1. Screenshot attached.
2. The issue is not reproducible with ETP - Standard
3. The issue is not reproducible on Windows.

Comment 1

[Thomas Wisniewski [:twisniewski]]

I cannot reproduce the issue on my Macbook. Oana, is it still reproducing for you on the latest nightly Firefox build? If so do you see any errors in the console as you click? I do see two of them, one where "ire" is undefined, and one where "fbq" is undefined, but neither seems to break my ability to navigate between categories.

Comment 2

[Oana Arbuzov [:oanaarbuzov]]

Attachment: Console.png

Tom, the issue is still reproducible after selecting the second category. I've attached the console log.

Tested with:
Browser / Version: Firefox Nightly 96.0a1 (2021-11-24)
Operating System: macOS Big Sur 11.6

Comment 3

[Oana Arbuzov [:oanaarbuzov]]

Tom, please check the provided attachment that shows the console log.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Ah, good, thanks! I was able to reproduce the error today, and it helped to see what you were seeing!

It turns out that this site is relying on an early Google Analytics command-queue which we're not handling properly in the SmartBlock shim, so it's missing the tracker object which should be set as ga.getAll()[0].

Thankfully this is simple enough to fix; I have a candidate patch almost ready.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1736850 - also process any pre-declared Google Analytics command queue in the SmartBlock shim; r?denschub

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62327f38ccfe
also process any pre-declared Google Analytics command queue in the SmartBlock shim; r=denschub,webcompat-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/62327f38ccfe

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced on Firefox Nightly 95.0a1 (2021-10-19), Firefox 95.0.

The issue is fixed on 97.0b8 and latest nightly 98.0a1.