Closed Bug 1736912 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 31334 - Fix CompositeAfterPaint backface-visibility regression

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31334 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31334
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Fix CompositeAfterPaint backface-visibility regression

Previously we set backface visibility to kVisible in the
TransformPaintPropertyNode for any css transform without explicit
backface-visibililty:hidden. This caused CompositeAfterPaint to
unnecessarily create composited layers for descendant transforms
of backface-visibility:hidden, and the composited layers had
incorrect backface visibility (which is crbug.com/1261095).

This CL let TransformPaintPropertyNode for transforms without
direct compositing reasons and backface-visibility-hidden inherit
parent backface-visibility to fix the regression.

Bug: 1260603
Change-Id: I5ad202b530ceaf20adb106bb7c626d3453c5bf1a
Reviewed-on: https://chromium-review.googlesource.com/3234662
WPT-Export-Revision: 9345c5023003271ab8e8e07eaa68bb2541163ad3

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a689e916df7
[wpt PR 31334] - Fix CompositeAfterPaint backface-visibility regression, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.