Closed Bug 1736971 Opened 3 years ago Closed 3 years ago

Intermittent Error: Assertion failed: got -1n, expected 65539n build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17

Categories

(Core :: JavaScript: WebAssembly, defect, P3)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: lth)

References

(Regression)

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(1 file)

Bug 1736971 - Make memory64 test more sophisticated. r?yury
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=355539785&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TI0xOAkeRPqaIGbpiJKciQ/runs/0/artifacts/public/logs/live_backing.log

[task 2021-10-21T06:24:34.803Z] 06:24:34     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.2 s]
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Stack:
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -    @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Exit code: 3
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  FAIL - wasm\memory64\basic.js
[task 2021-10-21T06:24:34.829Z] 06:24:34  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n (code 3, args "--wasm-memory64") [0.7 s]
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO exit-status     : 3
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO timed-out       : False
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO stderr         2> Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:34.830Z] 06:24:34     INFO -  INFO stderr         2> Stack:
[task 2021-10-21T06:24:34.830Z] 06:24:34     INFO -  INFO stderr         2> @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:34.832Z] 06:24:34     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.3 s]
[task 2021-10-21T06:24:35.003Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--baseline-eager") [0.2 s]
[task 2021-10-21T06:24:35.019Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.2 s]
[task 2021-10-21T06:24:35.022Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--blinterp-eager") [0.2 s]
[task 2021-10-21T06:24:35.041Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--wasm-compiler=optimizing") [0.2 s]
[task 2021-10-21T06:24:35.079Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--wasm-compiler=baseline") [0.2 s]
[task 2021-10-21T06:24:35.158Z] 06:24:35     INFO -  Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:35.173Z] 06:24:35     INFO -  Stack:
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -    @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -  Exit code: 3
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -  FAIL - wasm\memory64\basic.js
[task 2021-10-21T06:24:35.175Z] 06:24:35  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n (code 3, args "--wasm-memory64 --wasm-compiler=baseline") [0.6 s]
[task 2021-10-21T06:24:35.175Z] 06:24:35     INFO -  INFO exit-status     : 3
[task 2021-10-21T06:24:35.175Z] 06:24:35     INFO -  INFO timed-out       : False
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> Stack:
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:35.188Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Success (code 3, args "--wasm-memory64 --test-wasm-await-tier2") [0.7 s]
Summary: Intermittent Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n → Intermittent Error: Assertion failed: got -1n, expected 65539n build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17

I'll take this, it looks like I need an OOM check in the test case. See also bug 1736492 which is another kind of OOM for the same test case.

Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Regressed by: 1727084
Has Regression Range: --- → yes
Priority: P5 → P3

Three related changes here.

First, calls to grow() that are somewhat likely to fail due to OOM are
checked for OOM, and the test is abandoned if there is an OOM. This
is not considered a test failure.

Second, test the heap max and grow() more thoroughly by cleaning up
the logic and adding more configs to the test runner.

Third, test shared memories too - it was an oversight that these were
not tested before.

Set release status flags based on info from the regressing bug 1727084

status-firefox93: --- → unaffected
status-firefox94: --- → unaffected
status-firefox95: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa57c1fde77f
Make memory64 test more sophisticated. r=yury

https://hg.mozilla.org/mozilla-central/rev/aa57c1fde77f

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

(In reply to Pulsebot from comment #5)

Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa57c1fde77f
Make memory64 test more sophisticated. r=yury

== Change summary for alert #32305 (as of Mon, 08 Nov 2021 11:23:09 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
44% perf_reftest bidi-resolution-1.html macosx1015-64-shippable-qr e10s stylo webrender 17.01 -> 9.45
41% perf_reftest bidi-resolution-1.html macosx1015-64-shippable-qr e10s stylo webrender 17.24 -> 10.20
36% perf_reftest bidi-resolution-1.html macosx1015-64-shippable-qr e10s fission stylo webrender 18.93 -> 12.10

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32305

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: