1736971 - Intermittent Error: Assertion failed: got -1n, expected 65539n build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=355539785&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TI0xOAkeRPqaIGbpiJKciQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-10-21T06:24:34.803Z] 06:24:34     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.2 s]
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Stack:
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -    @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  Exit code: 3
[task 2021-10-21T06:24:34.823Z] 06:24:34     INFO -  FAIL - wasm\memory64\basic.js
[task 2021-10-21T06:24:34.829Z] 06:24:34  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n (code 3, args "--wasm-memory64") [0.7 s]
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO exit-status     : 3
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO timed-out       : False
[task 2021-10-21T06:24:34.829Z] 06:24:34     INFO -  INFO stderr         2> Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:34.830Z] 06:24:34     INFO -  INFO stderr         2> Stack:
[task 2021-10-21T06:24:34.830Z] 06:24:34     INFO -  INFO stderr         2> @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:34.832Z] 06:24:34     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.3 s]
[task 2021-10-21T06:24:35.003Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--baseline-eager") [0.2 s]
[task 2021-10-21T06:24:35.019Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.2 s]
[task 2021-10-21T06:24:35.022Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--blinterp-eager") [0.2 s]
[task 2021-10-21T06:24:35.041Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--wasm-compiler=optimizing") [0.2 s]
[task 2021-10-21T06:24:35.079Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\multi-value\block-run.js | Success (code 0, args "--wasm-compiler=baseline") [0.2 s]
[task 2021-10-21T06:24:35.158Z] 06:24:35     INFO -  Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:35.173Z] 06:24:35     INFO -  Stack:
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -    @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -  Exit code: 3
[task 2021-10-21T06:24:35.174Z] 06:24:35     INFO -  FAIL - wasm\memory64\basic.js
[task 2021-10-21T06:24:35.175Z] 06:24:35  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n (code 3, args "--wasm-memory64 --wasm-compiler=baseline") [0.6 s]
[task 2021-10-21T06:24:35.175Z] 06:24:35     INFO -  INFO exit-status     : 3
[task 2021-10-21T06:24:35.175Z] 06:24:35     INFO -  INFO timed-out       : False
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17 Error: Assertion failed: got -1n, expected 65539n
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> Stack:
[task 2021-10-21T06:24:35.176Z] 06:24:35     INFO -  INFO stderr         2> @Z:\task_163479575373753\build\tests\jit-test\jit-test\tests\wasm\memory64\basic.js:1410:17
[task 2021-10-21T06:24:35.188Z] 06:24:35     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\wasm\memory64\basic.js | Success (code 3, args "--wasm-memory64 --test-wasm-await-tier2") [0.7 s]

Comment 1

[Lars T Hansen [:lth]]

I'll take this, it looks like I need an OOM check in the test case. See also bug 1736492 which is another kind of OOM for the same test case.

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1736971 - Make memory64 test more sophisticated. r?yury

Three related changes here.

First, calls to grow() that are somewhat likely to fail due to OOM are
checked for OOM, and the test is abandoned if there is an OOM. This
is not considered a test failure.

Second, test the heap max and grow() more thoroughly by cleaning up
the logic and adding more configs to the test runner.

Third, test shared memories too - it was an oversight that these were
not tested before.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1727084

Comment 4

[Intermittent Failures Robot]

5 failures in 3186 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 5

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1736971&startday=2021-10-18&endday=2021-10-24&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa57c1fde77f
Make memory64 test more sophisticated. r=yury

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aa57c1fde77f

Comment 7

[Intermittent Failures Robot]

2 failures in 2845 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1736971&startday=2021-10-25&endday=2021-10-31&tree=all

Comment 8

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa57c1fde77f
Make memory64 test more sophisticated. r=yury

== Change summary for alert #32305 (as of Mon, 08 Nov 2021 11:23:09 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
44%	perf_reftest bidi-resolution-1.html	macosx1015-64-shippable-qr	e10s stylo webrender	17.01 -> 9.45
41%	perf_reftest bidi-resolution-1.html	macosx1015-64-shippable-qr	e10s stylo webrender	17.24 -> 10.20
36%	perf_reftest bidi-resolution-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	18.93 -> 12.10

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32305