173702 - Find in Page functionality broken

Status: RESOLVED WORKSFORME

(Core Graveyard :: Java APIs to WebShell, defect)

Description

[Ryan Wilhm]

The event handling in "java/webclient/src_moz/CurrentPageActionEvents.cpp" is
basically excluded at compile time by the preprocessor. ("#ifdef 0" is used in
"void * wcFindEvent::handleEvent()" to short circuit the compiler from ever
seeing the code.) I don't see anything wrong with it, so the following patch
just removes the macro and adds the appropriate header inclusion to get at the
nsIFindComponent interface.

Comment 1

[Ryan Wilhm]

Have emailed Ed about this earlier... meant to assign it to him.

Comment 2

[Ryan Wilhm]

Attachment: Fix for Find in Page

Just do a "patch -p0 < THISFILE.patch" in the mozilla/ source root. This patch
basically just restores CurrentPageActionEvents.cpp. I've built this and tested
it on Linux (RedHat 8.0), and haven't had any problems.

Comment 3

[edburns]

Hmm, this patch doesn't seem to compile on Win32:

     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(105)
: error C2955: 'nsCOMPtr' : use of class template requires template argument list
     [exec]        
c:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\dist\include\xpcom\nsCOMPtr.h(708)
: see declaration of 'nsCOMPtr'
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(105)
: error C2133: 'findComponent' : unknown size
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(105)
: error C2512: 'nsCOMPtr' : no appropriate default constructor available
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(105)
: error C2262: 'findComponent' : cannot be destroyed
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(106)
: error C2065: 'NS_IFINDCOMPONENT_CONTRACTID' : undeclared identifier
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(108)
: error C2678: binary '==' : no operator found which takes a left-hand operand
of type 'int' (or there is no acceptable conversion)
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(147)
: error C2039: 'CreateContext' : is not a member of 'nsCOMPtr'
     [exec]        
c:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\dist\include\xpcom\nsCOMPtr.h(708)
: see declaration of 'nsCOMPtr'
     [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
     [exec] Stop.
     [exec]
C:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\java\webclient\src_moz\CurrentPageActionEvents.cpp(188)
: error C2039: 'FindNext' : is not a member of 'nsCOMPtr'
     [exec] NMAKE : fatal error U1077: '"C:\Program
Files\Microsoft.NET\FrameworkSDK\Bin\nmake.exe"' : return code '0x2'
     [exec] Stop.
     [exec]        
c:\Projects\mozilla\MOZILLA_1_0_1_RELEASE\mozilla\dist\include\xpcom\nsCOMPtr.h(708)
: see declaration of 'nsCOMPtr'

Comment 4

[Ryan Wilhm]

I hadn't build on Windows before, just Linux. Will look at this, too.

Comment 5

[Kyle Yuan]

I've tested that on Windows 2000/RedHat 8, it works for me.