Closed Bug 1737024 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31340 - Don't expose a repeated table header to child iframes.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31340 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31340
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Don't expose a repeated table header to child iframes.

That was of course bad in the first place, but now with
LayoutNGFragmentTraversal enabled, the child iframe may be
fragment-traversable (because it's laid out with LayoutNG), while the
IFRAME element in the parent document may be inside legacy block
fragmentation. We'd end up creating multiple FragmentData objects for
the layout objects inside the IFRAME document, which is more harmful
with LayoutNGFragmentTraversal, since we expect that the number of
physical fragments be identical to the number of FragmentData objects.

Additionally reset the is_in_block_fragmentation flag when entering
frames. Leaving this unchanged didn't cause any known problems, but it's
wrong to let child frames inherit this state.

Bug: 1260855
Change-Id: Ic416f2213772d986da3597a86131e9d7956e21f9
Reviewed-on: https://chromium-review.googlesource.com/3234964
WPT-Export-Revision: dd15c232cda454631316e21416b224f6195857f4

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/866d09fd70fe
[wpt PR 31340] - Don't expose a repeated table header to child iframes., a=testonly

https://hg.mozilla.org/mozilla-central/rev/866d09fd70fe

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.