Closed Bug 1737032 Opened 3 years ago Closed 3 years ago

Remove traces of "remote XUL"

Categories

(Core :: XUL, defect)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: Gijs, Assigned: riasangwan1999, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++][lang=js][lang=html])

Attachments

(1 file)

The error message optimistically states this technology is not available "by default".

Except bug 1551344 removed what, AFAICT, was the last trace of NS_ERROR_REMOTE_XUL being assigned anywhere, which is the only way the error message gets shown. https://searchfox.org/mozilla-central/search?q=NS_ERROR_REMOTE_XUL only shows comparisons. So as far as I can tell, all of that code is dead, as well as all the code that depends on it, cf. https://searchfox.org/mozilla-central/search?q=remoteXUL&path=&case=true&regexp=false .

To fix this bug you need a compiled build of Firefox and you'd want to remove all these references, and ensure that the result still builds and works.

Can I work on this issue?

(In reply to riasangwan1999 from comment #1)

Can I work on this issue?

Yep; we normally assign bugs once a first version of a patch is up.

Thanks, I will update you here with the work soon.

Assignee: nobody → riasangwan1999

What will be the further work for me?

(In reply to riasangwan1999 from comment #5)

What will be the further work for me?

The patch you uploaded is marked as "work in progress", and not marked as ready for review. If you amend the commit message to include , r?gijs at the end and then run moz-phab submit again, that should add me as a reviewer and get rid of the "work in progress" flag.

Flags: needinfo?(riasangwan1999)

Okay, thank you. I wasn't aware of this.

Flags: needinfo?(riasangwan1999)
Attachment #9247257 - Attachment description: WIP: Bug 1737032 - Removed traces of "remote XUL" → Bug 1737032 - Removed traces of "remote XUL". r?gijs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0361e20ae9ad
Removed traces of "remote XUL". r=Gijs,fluent-reviewers
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: