1737108 - Differentiate distribution IDs in MSIX packages intended for the Microsoft Store

Status: VERIFIED FIXED

(Firefox :: Installer, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

Right now, we have no way to distinguish installs from Mozilla-signed MSIX packages and installs from Microsoft-signed MSIX packages distributed by the Microsoft Store. This ticket tracks differentiating the distribution IDs.

Another way to achieve a similar result is to capture the package (family) name in Telemetry as follow-up to Bug 1709892.

Comment 1

[Nick Alexander :nalexander [he/him]]

We have some questions about the existing telemetry from Bug 1709892, so I'm leaning towards doing this by including the app package name and publisher (or family name) in telemetry directly. This is more robust than reporting the distribution ID. When I try this, I will only include app package data if it's likely Mozilla produced the packages. The allow-list will be that the publisher is "Mozilla" or "MozillaCorporation", I think.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1697875 - WIP on Part 2: Annotate crash reports with Windows app package name and publisher. r?gsvelto

Depends on D130187

Comment 3

[Phabricator Automation]

Comment on attachment 9249827 [details]
WIP: Bug 1697875 - WIP on Part 2: Annotate crash reports with Windows app package name and publisher. r?gsvelto

Revision D130188 was moved to bug 1738375. Setting attachment 9249827 [details] to obsolete.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1737108: Part 1: Expose MSIX PackageFamilyName in nsSystemInfo. r?mhowell!

Comment 5

[[e-mail] (:bhearsum)]

Attachment: Bug 1737108: Part 2: Differentiate MSIX packages intended for the Microsoft Store and others in Telemetry. r?mhowell!,chutten!

This patch also removes the existing hasWinPackageId, because PackageFamilyName is essentially a richer version of the same thing (empty string is the same as !hasWinPackageId, and any non-empty string is the opposite, except we can distinguish between different packages).

Depends on D131520

Comment 6

[[e-mail] (:bhearsum)]

Chris, I was about to file a data request for this, but it's actually the exact same piece of data that I filed one for in https://bugzilla.mozilla.org/show_bug.cgi?id=1738375, except we'll now be sending it through Telemetry in addition to Crash Stats. Does that need a separate request, or does the existing one carry over? (In retrospect, I probably should've included information about both bugs in the original request...).

Comment 7

[Chris H-C :chutten]

The request should cover both, just put a comment over in bug 1738375 so it's clear to anyone hitting it in future.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2e3dd3db672
Part 1: Expose MSIX PackageFamilyName in nsSystemInfo. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/03d84f4e39a3
Part 2: Differentiate MSIX packages intended for the Microsoft Store and others in Telemetry. r=mhowell,chutten

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 9251410 [details]
WIP: Bug 1737108: Part 1: Expose MSIX PackageFamilyName in nsSystemInfo. r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: No direct user impact. The sooner we have this, the sooner we can analyze telemetry from MSIX installations in more depth.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: no

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f2e3dd3db672
https://hg.mozilla.org/mozilla-central/rev/03d84f4e39a3

Comment 11

[Catalin Sasca, QA [:csasca]]

Hey Ben! Is there anything testable here? If so, could you provide some steps in order to verify this? Thank you!

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9251410 [details]
WIP: Bug 1737108: Part 1: Expose MSIX PackageFamilyName in nsSystemInfo. r?mhowell!

Approved for landing on the beta branch before RC, thanks.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b76c2618242e
https://hg.mozilla.org/releases/mozilla-beta/rev/ddddabdfd7ae

Comment 14

[[e-mail] (:bhearsum)]

(In reply to Catalin Sasca, QA [:csasca] from comment #11)

Hey Ben! Is there anything testable here? If so, could you provide some steps in order to verify this? Thank you!

Yes, the new value ("winPackageFamilyName") should show up in the "Environment" section of about:telemetry

Comment 15

[Alexandru Trif, QA [:atrif]]

Thank you!

Verified on Windows 10x64 and Windows 11x64 that the "winPackageFamilyName" value is displayed inside about:telemetry#environment-data-tab using Firefox MSIX 96.0a1 (20211126050650) and 95.0b13 (20211126095952) from treehereder.