Closed Bug 1737111 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31350 - Fix 2 test expectations in rotate-composition.html.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31350 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31350
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Fix 2 test expectations in rotate-composition.html.

I previously adjusted the expectations for this test in
https://crrev.com/19620452a45a851f38799bcc2bd5ddb9d5b120ac . However, I
believe these two expectations were incorrect both before and after that
adjustment, and the behavior shown in both Chromium and Gecko is
correct. (WebKit differs slightly by producing 'none' rather than
'0deg'.)

I think this is correct because we're interpolating between two transforms:
(a) '1 2 3 360deg' (the result of an add)
(b) '0 1 0 100deg'
Since the normalized axes differ, this interpolation falls into the
rules for interpolation of matrices, as described in
https://drafts.csswg.org/css-transforms-2/#interpolation-of-transform-functions .
(The rules for the 'rotate' property incorrectly say that SLERP is
always used, but I think that should be fixed to match the rules for the
rotate() function. Either way, however, this test expectation should be
based on interpolation of matrices using SLERP.) Since the matrix for
(a) is the identity matrix, and the progress of the interpolation is at
0, the result is the identity matrix, which should (although the spec
should make this explicit) be represented as 0deg. This should be fixed
in https://github.com/w3c/csswg-drafts/issues/4516 .

Bug: 1180834
Change-Id: I0a5e15535da56949fc88bdf48423b41d409fe290
Fixed: 1006239
Reviewed-on: https://chromium-review.googlesource.com/3237448
WPT-Export-Revision: 7dc28c63fdf9635201fd4464bb70453ddc8cc15b

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 66 subtests

Status Summary

Firefox

OK : 1
PASS: 55
FAIL: 11

Chrome

OK : 1
PASS: 66

Safari

OK : 1
PASS: 22
FAIL: 44

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-transforms/animation/rotate-composition.html
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (-1) should be [0.27 0.53 0.8 10deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (0.25) should be [0.27 0.53 0.8 60deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (0.75) should be [0.27 0.53 0.8 80deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (1) should be [0.27 0.53 0.8 90deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (2) should be [0.27 0.53 0.8 130deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (0.25) should be [y 25deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (0.75) should be [y 75deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (2) should be [y 200deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (0.25) should be [y 25deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (0.75) should be [y 75deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (2) should be [y 200deg]: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d4e32857966
[wpt PR 31350] - Fix 2 test expectations in rotate-composition.html., a=testonly

https://hg.mozilla.org/mozilla-central/rev/8d4e32857966

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.