Closed Bug 1737118 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31351 - [css-flex] Make final height of a-r column flex items definite

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31351
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Make final height of a-r column flex items definite

This expands the scenarios where a flex basis is considered definite
and, consequently, where items' children's % heights can resolve.

We now consider a flex basis to be definite when it derives from an
aspect-ratio and definite cross size. We previously weren't catching
this case because the used flex basis starts as 'content', which we were
automatically rejecting, even though it is later resolved without doing
a layout.

As detailed in the bug, the spec is not very precise with the
definitions of flex-basis, flex basis, and flex base size. This new
behavior assumes that "flex base size" can be used in place of "flex
basis" in one place in the spec. The new behavior matches Firefox.

Fixed: 1243969
Change-Id: I16bd4c4d27f3364404ef441ccfd9451159c14e09
Reviewed-on: https://chromium-review.googlesource.com/3230397
WPT-Export-Revision: ec304ca073580a4b8456f7fa1a8946601c72d701

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98063332ae2b
[wpt PR 31351] - [css-flex] Make final height of a-r column flex items definite, a=testonly

https://hg.mozilla.org/mozilla-central/rev/98063332ae2b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.