Closed Bug 1737133 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31353 - [flex] Change ApplyStretchAlignmentToChild to use stretching.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31353 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31353
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[flex] Change ApplyStretchAlignmentToChild to use stretching.

When we set a forced block-size on a child it'll be that size ignoring
all other constraints.

This was problematic for tables, as we ignored the intrinsic block-size
of the tables.

Previously we'd manually calculate the "stretched" cross-axis size for
items, with tables we didn't consider the intrinsic block-size.

Here we skip the problem by just setting the stretch constraint on a
flex-item instead of the forced block-size.

Eventually we'll be able to remove the:
FlexItem::cross_axis_size_
member.

Bug: 1257572
Change-Id: I8824763e2fdb2c46328737a66c66ac3e4e3f279b

Reviewed-on: https://chromium-review.googlesource.com/3221603
WPT-Export-Revision: 094229f0855801847fe9afeea8d9c7a1c6e55fc4

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18069986fb89
[wpt PR 31353] - [flex] Change ApplyStretchAlignmentToChild to use stretching., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/18069986fb89

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.