Closed
Bug 1737144
Opened 3 years ago
Closed 3 years ago
Remove ScriptSource::containsAsmJS_ field
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
the ScriptSource::containsAsmJS field is used to determine if the script contains asm.js, but actually the flag means
whether the script contains "asm.js" directive, regardless of whether the asm.js code passes the validation or not.
So there can be inconsistency between ScriptSource::containsAsmJS and !!CompilationStencil.asmJS.
The ScriptSource::containsAsmJS field is used only when starting incremental encoding,
and since legacy XDR is removed, now we can check it directly by looking into CompilationStencil.asmJS.
so we can remove the field and accessor.
|
Assignee | |
Updated•3 years ago
|
Summary: Remove ScriptSource::containsAsmJS field → Remove ScriptSource::containsAsmJS_ field
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/2ae5fc7f1c46 Remove ScriptSource.containsAsmJS_ field. r=tcampbell
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•