Closed
Bug 173719
Opened 22 years ago
Closed 21 years ago
warnings in report.cgi
Categories
(Bugzilla :: Reporting/Charting, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bbaetz, Assigned: gerv)
Details
Attachments
(1 file)
2.77 KB,
patch
|
bbaetz
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
report.cgi is spewing warnings. Incomplete sampling: - arround line 97/98, $columns{''} may be undefined, so you get undefined warnings - The + in the template seems to be causing warnings, again with uninitilised values, Also, report.cgi is doing |use diagnostics|, which is a no-no. Please remove it.
Reporter | ||
Comment 1•22 years ago
|
||
The + thing is becuase not all of the the dimensions exist all the time. Similarly, the urls within the charts contain an 'empty' paramater/value pair (ie ...?foo=bar&=&baz=x), if the relevent dimention isn't required.
Assignee | ||
Comment 2•21 years ago
|
||
Fix a few bugs, and make sure every possible data value is 0 rather than undef before doing the total maths, because TT seems to be quite strict about that. Gerv
Reporter | ||
Comment 3•21 years ago
|
||
Comment on attachment 102511 [details] [diff] [review] Patch v.1 its actually perl which complains, not TT. This looks fine.
Attachment #102511 -
Flags: review+
Assignee | ||
Comment 4•21 years ago
|
||
Fixed. I'll keep more of an eye out in future. Checking in report.cgi; /cvsroot/mozilla/webtools/bugzilla/report.cgi,v <-- report.cgi new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/reports/report-table.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-table.html.tmpl,v <-- report-table.html.tmpl new revision: 1.2; previous revision: 1.1 done Gerv
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.18
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•