173719 - warnings in report.cgi

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Bradley Baetz (:bbaetz)]

report.cgi is spewing warnings. Incomplete sampling:

- arround line 97/98, $columns{''} may be undefined, so you get undefined warnings
- The + in the template seems to be causing warnings, again with uninitilised
values,

Also, report.cgi is doing |use diagnostics|, which is a no-no. Please remove it.

Comment 1

[Bradley Baetz (:bbaetz)]

The + thing is becuase not all of the the dimensions exist all the time.
Similarly, the urls within the charts contain an 'empty' paramater/value pair
(ie ...?foo=bar&=&baz=x), if the relevent dimention isn't required.

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Fix a few bugs, and make sure every possible data value is 0 rather than undef
before doing the total maths, because TT seems to be quite strict about that.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 102511 [details] [diff] [review]
Patch v.1

its actually perl which complains, not TT.

This looks fine.

Comment 4

[Gervase Markham [:gerv]]

Fixed. I'll keep more of an eye out in future.

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/reports/report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-table.html.tmpl,v
 <--  report-table.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Gerv