1737196 - [rust 1.56] trailing semicolon in macro used in expression position

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-10-21T22:25:50.354Z] 22:25:50     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:50.354Z] 22:25:50     INFO -     --> testing\geckodriver\src\main.rs:118:63
[task 2021-10-21T22:25:50.354Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.354Z] 22:25:50     INFO -  118 |         return Err(FatalError::Usage(format!($fmt, $($arg)+)));
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -      |                                                               ^
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -  ...
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -  154 |             Err(e) => usage!("invalid --port: {}: {}", e, s),
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -      |                       -------------------------------------- in this macro invocation
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.355Z] 22:25:50     INFO -      = note: `-D semicolon-in-expressions-from-macros` implied by `-D warnings`
[task 2021-10-21T22:25:50.356Z] 22:25:50     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:50.356Z] 22:25:50     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:50.356Z] 22:25:50     INFO -      = note: this error originates in the macro `usage` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:50.356Z] 22:25:50     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:50.357Z] 22:25:50     INFO -     --> testing\geckodriver\src\main.rs:118:63
[task 2021-10-21T22:25:50.357Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.357Z] 22:25:50     INFO -  118 |         return Err(FatalError::Usage(format!($fmt, $($arg)+)));
[task 2021-10-21T22:25:50.357Z] 22:25:50     INFO -      |                                                               ^
[task 2021-10-21T22:25:50.357Z] 22:25:50     INFO -  ...
[task 2021-10-21T22:25:50.358Z] 22:25:50     INFO -  159 |         Err(e) => usage!("{}: {}:{}", e, host, port),
[task 2021-10-21T22:25:50.358Z] 22:25:50     INFO -      |                   ---------------------------------- in this macro invocation
[task 2021-10-21T22:25:50.358Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.358Z] 22:25:50     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:50.359Z] 22:25:50     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:50.359Z] 22:25:50     INFO -      = note: this error originates in the macro `usage` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:50.359Z] 22:25:50     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:50.359Z] 22:25:50     INFO -     --> testing\geckodriver\src\main.rs:118:63
[task 2021-10-21T22:25:50.360Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.360Z] 22:25:50     INFO -  118 |           return Err(FatalError::Usage(format!($fmt, $($arg)+)));
[task 2021-10-21T22:25:50.360Z] 22:25:50     INFO -      |                                                                 ^
[task 2021-10-21T22:25:50.360Z] 22:25:50     INFO -  ...
[task 2021-10-21T22:25:50.360Z] 22:25:50     INFO -  162 | /         usage!(
[task 2021-10-21T22:25:50.361Z] 22:25:50     INFO -  163 | |             "invalid --host: {}. Must be a local loopback interface",
[task 2021-10-21T22:25:50.361Z] 22:25:50     INFO -  164 | |             host
[task 2021-10-21T22:25:50.361Z] 22:25:50     INFO -  165 | |         )
[task 2021-10-21T22:25:50.361Z] 22:25:50     INFO -      | |_________- in this macro invocation
[task 2021-10-21T22:25:50.361Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.362Z] 22:25:50     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:50.362Z] 22:25:50     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:50.362Z] 22:25:50     INFO -      = note: macro invocations at the end of a block are treated as expressions
[task 2021-10-21T22:25:50.362Z] 22:25:50     INFO -      = note: to ignore the value produced by the macro, add a semicolon after the invocation of `usage`
[task 2021-10-21T22:25:50.362Z] 22:25:50     INFO -      = note: this error originates in the macro `usage` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:50.363Z] 22:25:50     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:50.363Z] 22:25:50     INFO -     --> testing\geckodriver\src\main.rs:118:63
[task 2021-10-21T22:25:50.363Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.363Z] 22:25:50     INFO -  118 |         return Err(FatalError::Usage(format!($fmt, $($arg)+)));
[task 2021-10-21T22:25:50.364Z] 22:25:50     INFO -      |                                                               ^
[task 2021-10-21T22:25:50.364Z] 22:25:50     INFO -  ...
[task 2021-10-21T22:25:50.364Z] 22:25:50     INFO -  177 |             Err(e) => usage!("invalid --marionette-port: {}", e),
[task 2021-10-21T22:25:50.364Z] 22:25:50     INFO -      |                       ------------------------------------------ in this macro invocation
[task 2021-10-21T22:25:50.364Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.365Z] 22:25:50     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:50.365Z] 22:25:50     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:50.365Z] 22:25:50     INFO -      = note: this error originates in the macro `usage` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:50.365Z] 22:25:50     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:50.365Z] 22:25:50     INFO -     --> testing\geckodriver\src\main.rs:118:63
[task 2021-10-21T22:25:50.366Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.366Z] 22:25:50     INFO -  118 |         return Err(FatalError::Usage(format!($fmt, $($arg)+)));
[task 2021-10-21T22:25:50.366Z] 22:25:50     INFO -      |                                                               ^
[task 2021-10-21T22:25:50.366Z] 22:25:50     INFO -  ...
[task 2021-10-21T22:25:50.366Z] 22:25:50     INFO -  187 |             Err(e) => usage!("invalid --websocket-port: {}", e),
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -      |                       ----------------------------------------- in this macro invocation
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -      |
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -      = note: this error originates in the macro `usage` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:50.367Z] 22:25:50     INFO -  error: could not compile `geckodriver` due to 5 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1737196 - Remove semicolon in rust macro.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f40d32e7c37c
Remove semicolon in rust macro. r=webdriver-reviewers,jgraham

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f40d32e7c37c