1737217 - (-Wunused-but-set-parameter) Enable -Wunused-but-set-parameter warnings

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Chris Peterson [:cpeterson]]

clang 13 added a new -Wunused-but-set-parameter warning:

https://releases.llvm.org/13.0.0/tools/clang/docs/DiagnosticsReference.html#wunused-but-set-parameter

gcc has had an -Wunused-but-set-parameter since gcc 4.6, though the few warnings I've seen from it were all false positives.

https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Warning-Options.html

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1737217 - Stop incrementing aOffset parameter that is never used. r?#necko-reviewers

This change fixes the following -Wunused-but-set-parameter warning:

netwerk/test/fuzz/FuzzingStreamListener.cpp:18:49: warning: parameter 'aOffset' set but not used [-Wunused-but-set-parameter]

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1737217 - Enable -Wunused-but-set-parameter warnings on clang. r?#firefox-build-system-reviewers

But don't enable on gcc because it reports false positives, such as:

js/src/jsapi-tests/testJitABIcalls.cpp:445:61: warning: parameter 'lineno' set but not used [-Wunused-but-set-parameter]
js/src/jsapi-tests/testJitABIcalls.cpp:461:56: warning: parameter 'base' set but not used [-Wunused-but-set-parameter]

Even though those parameters are used here:

https://searchfox.org/mozilla-central/source/js/src/jsapi-tests/testJitABIcalls.cpp#445,450,461,464

Depends on D129350

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ec3b454039
Stop incrementing aOffset parameter that is never used. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/9a7479044bb4
Enable -Wunused-but-set-parameter warnings on clang. r=firefox-build-system-reviewers,glandium

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a9ec3b454039
https://hg.mozilla.org/mozilla-central/rev/9a7479044bb4

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.