Closed Bug 1737287 Opened 3 years ago Closed 2 years ago

CFR doorhanger dropdown regression truncates content

Categories

(Firefox :: Messaging System, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
95 Branch
Iteration:
95.2 - Oct 18 - Oct 31
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- verified

People

(Reporter: dmosedale, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached is an example. Thanks to Mardak for bisecting; the regression happened in one of these commits. Looking through them, the recent popup link alignment changes from bug 1706534 appear to be the likely trigger; perhaps the hbox/vbox/flex changes in particular.

Steps to reproduce:

  • use about:config to enable browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
  • in a new tab, click the wrench icon below the gear icon in the upper right
  • search the page content for the word "PERSONAL"
  • click the "Show" button to the right of that word
  • Once the "Personalized CFR Recommendation" button appears in the URL bar, click it
Summary: CFR doorhanger dropdowns truncate content towards the end → CFR doorhanger dropdown regression truncates content

Set release status flags based on info from the regressing bug 1706534

:dao, can you have a look?

Flags: needinfo?(dao+bmo)
Regressed by: cfr
Has Regression Range: --- → yes
Iteration: --- → 95.2 - Oct 18 - Oct 31
Component: Theme → Messaging System
Severity: -- → S4
Priority: -- → P1

The STR didn't work for me, since a console error was printed when I tried to show the message:

JavaScript error: resource://activity-stream/lib/CFRPageActions.jsm, line 339: TypeError: can't access property "attributes", localeStrings is null

but I can trigger the bug by showing the message DOH_ROLLOUT_CONFIRMATION_89.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Points: --- → 2
Flags: needinfo?(dao+bmo)

This reverts one change from 1706534 but does not regress tha bug.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a9ab1a93f43
Restore flex alignment to popupnotifications. r=mtigley

The reproduction issue makes sense, as it depends on a fix to the devtools that I haven't landed. Thanks so much for your help here, Harry!

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

I have verified that this issue is no longer reproducible by following the steps provided in the description using Firefox 95.0b3 en-US, de, fr, it, and RU (Build ID: 20211104185958) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: