1737316 - Flashing alarms not shown in multiday views.

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to Reproduce

1. Go to the week view.
2. Create an event (not all-day) that starts in one minute with an alarm.
3. Wait one minute for the alarm notification to popup.

Result

The alarm icon is not shown with the red background (flashing) in the week view.

Expect

The alarm icon to be flashing. Note if you create an event in the past with an alarm (such that the alarm notification shows immediately after saving the event), you will see the flashing icon.

Origin

The code that sets the flashing alarm expects an eventbox property that doesn't exist https://searchfox.org/comm-central/rev/e6dbce863262e1c938a06c6c66d52d22bdcb24a7/calendar/base/content/calendar-multiday-view.js#2980

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1737316 - Set the "flashing" attribute on the calendar-editable-item directly. r=darktrojan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2b9981d6559
Set the "flashing" attribute on the calendar-editable-item directly. r=darktrojan

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9247310 [details]
Bug 1737316 - Set the "flashing" attribute on the calendar-editable-item directly. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Flashing alarms do not work in week and day views.
Testing completed (on c-c, etc.): No tests.
Risk to taking this patch (and alternatives if risky): Low risk and small patch.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9247310 [details]
Bug 1737316 - Set the "flashing" attribute on the calendar-editable-item directly. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/5a9c5bcae88d