1737365 - Crash in [@ mozilla::layers::SurfacePoolCA::LockedPool::ReturnSurfaceToPool]

Status: RESOLVED WORKSFORME

(Core :: Graphics: Layers, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/0c2bf6e2-5e13-4354-8e19-769f80211022

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(inUseEntryIter != mInUseEntries.end())

Top 10 frames of crashing thread:

0 XUL mozilla::layers::SurfacePoolCA::LockedPool::ReturnSurfaceToPool gfx/layers/SurfacePoolCA.mm:181
1 XUL mozilla::layers::NativeLayerCA::~NativeLayerCA gfx/layers/NativeLayerCA.mm:672
2 XUL mozilla::layers::NativeLayerCA::~NativeLayerCA gfx/layers/NativeLayerCA.mm:662
3 XUL mozilla::layers::NativeLayerRootCA::SetWindowIsFullscreen gfx/layers/NativeLayerCA.mm:491
4 XUL nsCocoaWindow::DoMakeFullScreen widget/cocoa/nsCocoaWindow.mm:1675
5 XUL nsGlobalWindowOuter::SetWidgetFullscreen dom/base/nsGlobalWindowOuter.cpp:4649
6 XUL FullscreenTransitionTask::Run dom/base/nsGlobalWindowOuter.cpp:4406
7 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:770
8 XUL NS_ProcessPendingEvents xpcom/threads/nsThreadUtils.cpp:432
9 XUL nsAppShell::ProcessGeckoEvents widget/cocoa/nsAppShell.mm:505

While I was helping to investigate bug 1734854 by doing a bisection, I had the space station stream open from Bug 1734854 comment 13, and occasionally popped it in or out of full screen (to try to make sure I remembered what the behavior was like in my original profile). A few minutes after I finished doing the bisection, I went back to my original browser and was again entering or exiting full screen on the tab for that video, and I hit this release assert.

Comment 1

[Andrew McCreight [:mccr8]]

I'm on a 10-22 Nightly build.

Comment 2

[Andrew McCreight [:mccr8]]

It looks like this release assert is also being hit on beta, under a slightly different signature: bp-fe292055-9bad-41b4-86e6-3380b0211021

The crashes all have DoMakeFullScreen in the stacks.

Comment 3

[Brad Werth [:bradwerth]]

If this is only occurring with the combination of macOS video fullscreen shortly after a fullscreen transition, then the patch for Bug 1736446 may be relevant. Can anyone consistently reproduce in a local build?

Comment 4

[Andrew McCreight [:mccr8]]

Unfortunately I haven't been able to reproduce the crash.

For what it is worth, the earlier build I found with this release assert with DoMakeFullScreen in the stack was this one (it shows up on much older branches, but the stacks look different) from the 20210929155324 build: bp-71a2bc5b-539b-4349-b855-335200210930

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Low-volume crash so far on Beta94, but holding off on a full wontfix until we see what it does on Release next week.

Comment 6

[Jim Mathies [:jimm]]

This hasn't shown up since 94.