Closed Bug 1737375 Opened 4 years ago Closed 4 years ago

Switch expected type of aboutwelcome feature variable "screens" from "json"

Categories

(Firefox :: Nimbus Desktop Client, task)

Product:
Firefox
Component:
Nimbus Desktop Client
Type:
task

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: Mardak, Unassigned)

References

Details

https://searchfox.org/mozilla-central/rev/2e3b0483e31abffe0b4374480a34c6d23f5186ea/toolkit/components/nimbus/FeatureManifest.js#85,98-99

It's currently set to "json" which seems like it gets converted to "string" which then prevents an array configuration value from being set.

Looks like "array" isn't supported yet, so we might need to depend on something first.

https://github.com/mozilla/experimenter/blob/1be1a85fe541de93c029b95611ac416b0e8234f0/app/experimenter/features/__init__.py#L20-L24

With https://github.com/mozilla/experimenter/commit/b1e4ee84ff786b3b54837535e50a5fb56aa66d84 it seems like the appropriate type is indeed "json" and the schema won't require it to be "string"

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.