Open Bug 1737379 Opened 3 years ago Updated 2 years ago

accessing talos performance profiles from treeherder is confusing

Categories

(Tree Management :: Treeherder, defect)

defect

Tracking

(Not tracked)

People

(Reporter: bholley, Unassigned)

References

Details

I was recently trying to track down a rather large regression in bug 1736796. I figured I'd start with the sessionstore regression, so I did a try push with talos-other [1].

Clicking on the 'o' job, I saw the "Generate Performance Profile". That sounded super neat, so I clicked it, which generated the 'o-p' job. So far, so good.

However, the o-p job only shows performance results for 'fetch_content', which is only one of about a dozen tests in the regular 'o' job.

Moreover, when I click 'Open in Firefox Profiler', I only get profiles for the first subtest (a11y dhtml.html).

If I click over to "Artifacts", I can actually find the profiles for all the subtests, but it wasn't obvious.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=b550b284f44d2af334e0dd7d84f9388f3d0f734c

:davehunt, I am not sure of the actual work required here, but at first read this sounds like something in the perf tooling needs adjusting. Can you confirm?

Flags: needinfo?(dave.hunt)

However, the o-p job only shows performance results for 'fetch_content', which is only one of about a dozen tests in the regular 'o' job.

We prevent results with the Profiler enabled from being ingested into Perfherder because in the past we had no way to separate them from results without the Profiler enabled. This will soon be fixed for Raptor via bug 1635983. We'll likely need another bug to fix this in Talos.

Moreover, when I click 'Open in Firefox Profiler', I only get profiles for the first subtest (a11y dhtml.html).

For Raptor with multiple iterations we present a single archive for the Profiler, which allows the user to select the profile to open. It sounds like we should do the same for Talos tasks with multiple tests.

:sparky I know you've worked on the Profiler integration for Raptor / mozperftest. If my comments here seem reasonable, can you file the appropriate bugs as blockers for this one?

Flags: needinfo?(dave.hunt) → needinfo?(gmierz2)
Depends on: 1737639
Depends on: 1737641

Sure thing, they've been filed.

Flags: needinfo?(gmierz2)
You need to log in before you can comment on or make changes to this bug.