Closed Bug 1737389 Opened 2 years ago Closed 2 years ago

Red outline of the find bar when the phrase not found is clipped on the left side

Categories

(Toolkit :: Find Toolbar, defect, P3)

Product:
Toolkit
Component:
Find Toolbar
Version:
Firefox 92
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- verified
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- verified

People

(Reporter: cpeterson, Assigned: raquelvargas, Mentored)

References

(Regression)

Details

(Keywords: good-first-bug, regression, Whiteboard: [lang=css])

Attachments

(2 files, 1 obsolete file)

screenshot.png
9.65 KB, image/png
Details
Bug 1737389 - Fixes red line of the bar around the left side when not found. r?harry
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-esr91+
Details | Review
Attached image screenshot.png —

+++ This bug was initially created as a clone of Bug #1733660 +++

Steps to reproduce

  1. Open the find bar with Cmd+F or Ctrl+F.
  2. Search for some string that is not found on the page.

Result

The red outline of the find bar when the phrase not found is clipped on the left side. See the attached screenshot.

Has Regression Range: --- → yes

We just need to change this line to outline-offset: -2px; to match these lines.

Mentor: htwyford
Severity: -- → S4
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=css]
Assignee: nobody → raquelvargas
Status: NEW → ASSIGNED
Attachment #9247646 - Attachment is obsolete: true
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/445b2b503282
Fixes red line of the bar around the left side when not found. r=harry,desktop-theme-reviewers

https://hg.mozilla.org/mozilla-central/rev/445b2b503282

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Flags: qe-verify+

Reproduced this on an affected Nightly build 95.0a1 (2021-10-23) on Win 10x64.

Verified as fixed on Beta 95.0b2 (20211102190739) across following platforms: Win 10x64, macOS 10.15 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox95: fixed → verified
Flags: qe-verify+

Seems like a pretty trivial polish - did you want to uplift this to ESR?

Flags: needinfo?(htwyford)

Comment on attachment 9247821 [details]
Bug 1737389 - Fixes red line of the bar around the left side when not found. r?harry

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: UI polish with a trivial patch.
  • User impact if declined: The border around the findbar will have an inconsistently-sized border.
  • Fix Landed on Version: 95
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One line CSS patch.
  • String or UUID changes made by this patch:
Flags: needinfo?(htwyford)
Attachment #9247821 - Flags: approval-mozilla-esr91?
Attachment #9247821 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Verified as fixed on Firefox 91.4.0esr (20211124155212) across the following platforms: Win 10x64, macOS 10.15 and Ubuntu 20.04.

status-firefox-esr91: fixed → verified
You need to log in before you can comment on or make changes to this bug.