Remove FTP from Match Pattern errors message
Categories
(WebExtensions :: General, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: erosman, Unassigned)
Details
Subsequent to Stopping FTP support in Firefox 90 , it would be more consistent to remove the FTP from Match Pattern errors message.
Type error for parameter userScriptOptions (Error processing matches.2: Value "*://*mozilla.org/*" must either: be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|\*):\/\/(\*|\*\.[^*/]+|[^*/]+)\/.*$/, or match the pattern /^file:\/\/\/.*$/], or match the pattern /^resource:\/\/(\*|\*\.[^*/]+|[^*/]+)\/.*$|^about:/) for userScripts.register.
|
||
Comment 1•4 years ago
|
||
This is an automated message based on the schema. We need to keep ftp in schema to avoid breaking older addons that have not yet updated. But we should probably have some plan on deprecating ftp from the schema.
|
||
Comment 2•4 years ago
|
||
We should be able to ignore unsupported values, e.g. by treating them as warnings.
|
|
||
Comment 3•4 years ago
|
||
I read this as removing ftp from the match pattern so it wouldn't show up in the error when there is one.
|
|
||
Comment 4•4 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
I read this as removing ftp from the match pattern so it wouldn't show up in the error when there is one.
The message currently appears if an extension specified an invalid match pattern.
comment 2 is about treating unrecognized match patterns as warnings instead of fatal errors, so that extensions that currently use ftp won't suddenly fail to load. In the WECG we've noted that we should gracefully handle unknown values instead of rejecting extensions, e.g. at https://github.com/w3c/webextensions/issues/14
Description
•