1737482 - Object inspector doesn't show properties and prototype of promises

Status: RESOLVED FIXED

(DevTools :: Object Inspector, defect)

Description

[Oriol Brufau [:Oriol]]

What were you doing?

Enter this code into the console:

inspect(Object.assign(Promise.resolve(123), {foo: 1}))

What happened?

▼ Promise { <state>: "fulfilled", <value>: 123 }
​│   <state>: "fulfilled"
​│   <value>: 123

What should have happened?

▼ Promise { <state>: "fulfilled", <value>: 123 }
​│   foo: 1
​│   <state>: "fulfilled"
​│   <value>: 123
​│   <prototype>: Promise.prototype { … }

Anything else we should know?

I broke this in bug 1552648, I guess I just copied what was being done for proxies, which are not supposed to show properties nor prototype. And I didn't notice the change since I was testing promises with a null prototype (in order to nest them), and <prototype> is not shown for a null prototype (bug 1612127).

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1737482 - [devtools] Include properties and prototype when inspecting promise. r?nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32ab6b8790bb
[devtools] Include properties and prototype when inspecting promise. r=nchevobbe

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/32ab6b8790bb

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1552648