Closed Bug 1737600 Opened 3 months ago Closed 3 months ago

3.75 - 0.97% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors (Windows) regression on Tue October 19 2021

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed

People

(Reporter: aesanu, Assigned: saschanaz)

References

(Regression)

Details

(Keywords: perf-alert, regression)

Attachments

(1 file)

Perfherder has detected a build_metrics performance regression from push cd6b1ef630f92bbdb7859a9ef9c86081e15fe761. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
4% compiler_metrics num_static_constructors windows2012-64-shippable 102.33 -> 106.17
1% compiler_metrics num_static_constructors windows2012-64-shippable 103.00 -> 104.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(krosylight)

I'm not sure what this means, is it just limiting the number of static constructors? I don't think the patches added any, other than those autogenerated by IPC layer in https://hg.mozilla.org/integration/autoland/rev/eea1902610ebb685edd22e1e3def52c3e8c39f0f. (Wait, I don't think it added any either?)

Could you give me some details here?

Flags: needinfo?(krosylight) → needinfo?(aesanu)

Is this coming from static nsTHashMap<ContentPrincipalInfoHashKey, WeakPtr<ManagedLocks>> sManagedLocksMap;
Could it use StaticAutoPtr?

Yeah, it is almost certainly sManagedLocksMap.

Hmm, seems there is no StaticWeakPtr 🤔🤔

Flags: needinfo?(aesanu)

There's no need for StaticWeakPtr? I guess Olli meant StaticAutoPtr<nsTHashMap<...>>?

Oh, that makes sense, thanks. I guess I got something to study 😅

(In reply to Olli Pettay [:smaug] from comment #2)

Could it use StaticAutoPtr?

Pretty sure I didn't say StaticWeakPtr ^ ;)

Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c09515c499f
Use StaticAutoPtr for sManagedLocksMap r=smaug
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.